Ensure autolinks still function properly with the revised embed parsing

Author: colinodell

tests/functional/Extension/Embed/EmbedExtensionTest.php

@@ -15,6 +15,7 @@
 
 use League\CommonMark\ConverterInterface;
 use League\CommonMark\Environment\Environment;
+use League\CommonMark\Extension\Autolink\AutolinkExtension;
 use League\CommonMark\Extension\CommonMark\CommonMarkCoreExtension;
 use League\CommonMark\Extension\Embed\EmbedExtension;
 use League\CommonMark\MarkdownConverter;
@@ -30,10 +31,17 @@ protected function createConverter(array $config = []): ConverterInterface
     {
         $config['embed']['adapter'] = new FakeAdapter();
 
+        $enableAutolinkExtension = $config['enable_autolinks'] ?? false;
+        unset($config['enable_autolinks']);
+
         $environment = new Environment($config);
         $environment->addExtension(new CommonMarkCoreExtension());
         $environment->addExtension(new EmbedExtension());
 
+        if ($enableAutolinkExtension) {
+            $environment->addExtension(new AutolinkExtension());
+        }
+
         return new MarkdownConverter($environment);
     }
 

tests/functional/Extension/Embed/data/embeds-with-autolinks-enabled.html

@@ -0,0 +1,27 @@
+<p>This is an embed:</p>
+<iframe class="embed" src="https://www.youtube.com/watch?v=dQw4w9WgXcQ"></iframe>
+<p>So is this, with only three spaces of indentation:</p>
+<iframe class="embed" src="https://www.youtube.com/watch?v=dQw4w9WgXcQ"></iframe>
+<p>This is not, because it's fully indented:</p>
+<pre><code>https://www.youtube.com/watch?v=dQw4w9WgXcQ
+</code></pre>
+<p>This is not, because it has extra bits after the URL:</p>
+<p><a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ">https://www.youtube.com/watch?v=dQw4w9WgXcQ</a> &lt;-- you gotta watch this!</p>
+<p>This is not, because it's in a fenced code block:</p>
+<pre><code class="language-md">
+https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+</code></pre>
+<p>And this isn't either because it's inline: <img src="https://www.youtube.com/watch?v=dQw4w9WgXcQ" alt="" /></p>
+<p>Embeds can't be nested in other blocks:</p>
+<ul>
+<li>https://www.youtube.com/watch?v=dQw4w9WgXcQ
+<ul>
+<li>https://www.youtube.com/watch?v=dQw4w9WgXcQ</li>
+</ul>
+</li>
+</ul>
+<p>This isn't valid because it's a lazy paragraph continuation:
+<a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ">https://www.youtube.com/watch?v=dQw4w9WgXcQ</a></p>
+<iframe class="embed" src="https://www.youtube.com/watch?v=dQw4w9WgXcQ"></iframe>
+<p>^ This is fine, though</p>

tests/functional/Extension/Embed/data/embeds-with-autolinks-enabled.md

@@ -0,0 +1,40 @@
+---
+enable_autolinks: true
+---
+
+This is an embed:
+
+https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+So is this, with only three spaces of indentation:
+
+   https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+This is not, because it's fully indented:
+
+    https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+This is not, because it has extra bits after the URL:
+
+https://www.youtube.com/watch?v=dQw4w9WgXcQ <-- you gotta watch this!
+
+This is not, because it's in a fenced code block:
+
+```md
+
+https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+```
+
+And this isn't either because it's inline: ![](https://www.youtube.com/watch?v=dQw4w9WgXcQ)
+
+Embeds can't be nested in other blocks:
+
+- https://www.youtube.com/watch?v=dQw4w9WgXcQ
+    - https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+This isn't valid because it's a lazy paragraph continuation:
+https://www.youtube.com/watch?v=dQw4w9WgXcQ
+
+https://www.youtube.com/watch?v=dQw4w9WgXcQ
+^ This is fine, though