Skip to content

esdm lint is very much opinionated #27

Description

@gossi

What is this bug about?

esdm lint is very opinionated about some rules and they go against my design. One particular: "event name redundantly starts with its aggregate name."

Well, very good - thank you for confirmation... I guess (?). I do have multiple *-cataloged events. I want other parts to listen to those. Neither in code nor elsewhere I want to alias a generic cataloged event to skill-cataloged or similar. That's why they were carefully chosen to include that name.

More on that, these events translate to code. Here is the command part to it:

https://github.com/gossi/sportipedia/blob/8f034ddaf1ac2fdaed09da3c69a5c2318f716b55/services/api/lib/sportipedia/catalog/equipment/router.ex

Imagine I would only have a Catalog, Edit or Archive command and would need each to alias them. The same goes for events.

I would prefer the inverted rule here: An event (and command) only consisting of a single word/verb would be an issue. As later in code, it would not be recognizable if in the code you only find the word Archive or Cataloged.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions