Move JS to theme (#126)

Author: flying-sheep

docs/conf.py

@@ -77,17 +77,15 @@ def test_search(value: str, pattern: str) -> bool:
 
 rtd_links_prefix = PurePosixPath("src")
 
-rtd_ver = os.environ.get("READTHEDOCS_VERSION", "")
-if re.fullmatch(r"\d+", rtd_ver):  # PR versions don’t have a own search index
+# PR versions don’t have a own search index
+if re.fullmatch(r"\d+", os.environ.get("READTHEDOCS_VERSION", "")):
     rtd_sphinx_search_default_filter = (
         f"subprojects:{os.getenv('READTHEDOCS_PROJECT')}/latest"
     )
 
 
 def setup(app: Sphinx) -> None:
     """Set up custom Sphinx extension."""
-    if rtd_ver:  # if we’re on ReadTheDocs, hide the pydata-sphinx-theme search popup
-        app.add_js_file("scripts/rtd-sphinx-search.js", loading_method="defer")
     app.add_object_type(
         "confval",
         "confval",

src/scanpydoc/theme/__init__.py

@@ -70,6 +70,7 @@
 
 from __future__ import annotations
 
+import os
 from typing import TYPE_CHECKING
 from pathlib import Path
 
@@ -87,4 +88,9 @@
 def setup(app: Sphinx) -> dict[str, bool]:  # pragma: no cover
     """Set up theme (like an extension)."""
     app.add_html_theme("scanpydoc", str(HERE))
+
+    # if we’re on ReadTheDocs, hide the pydata-sphinx-theme search popup
+    if os.environ.get("READTHEDOCS_VERSION", ""):  # pragma: no cover
+        app.add_js_file("scripts/rtd-sphinx-search.js", loading_method="defer")
+
     return dict(parallel_read_safe=True, parallel_write_safe=True)