Default trade confirmations to off

Author: thegeronimo

src/hyperopen/trading_settings.cljs

@@ -8,17 +8,17 @@
   {:fill-alerts-enabled? true
    :animate-orderbook? true
    :show-fill-markers? false
-   :confirm-open-orders? true
-   :confirm-close-position? true})
+   :confirm-open-orders? false
+   :confirm-close-position? false})
 
 (defn normalize-state
   [value]
   (let [settings (if (map? value) value {})]
     {:fill-alerts-enabled? (not (false? (:fill-alerts-enabled? settings)))
      :animate-orderbook? (not (false? (:animate-orderbook? settings)))
      :show-fill-markers? (true? (:show-fill-markers? settings))
-     :confirm-open-orders? (not (false? (:confirm-open-orders? settings)))
-     :confirm-close-position? (not (false? (:confirm-close-position? settings)))}))
+     :confirm-open-orders? (true? (:confirm-open-orders? settings))
+     :confirm-close-position? (true? (:confirm-close-position? settings))}))
 
 (defn restore-state
   []

test/hyperopen/startup/restore_test.cljs

@@ -212,8 +212,8 @@
         (restore-fn store)
         (is (= true (get-in @store [:trading-settings :animate-orderbook?])))
         (is (= false (get-in @store [:trading-settings :show-fill-markers?])))
-        (is (= true (get-in @store [:trading-settings :confirm-open-orders?])))
-        (is (= true (get-in @store [:trading-settings :confirm-close-position?])))))))
+        (is (= false (get-in @store [:trading-settings :confirm-open-orders?])))
+        (is (= false (get-in @store [:trading-settings :confirm-close-position?])))))))
 
 (deftest restore-trading-settings-valid-storage-restores-phase-1-5-settings-test
   (let [store (atom {})
@@ -232,6 +232,20 @@
         (is (= false (get-in @store [:trading-settings :confirm-open-orders?])))
         (is (= false (get-in @store [:trading-settings :confirm-close-position?])))))))
 
+(deftest restore-trading-settings-missing-confirmation-keys-defaults-to-disabled-test
+  (let [store (atom {})
+        restore-fn (restore-trading-settings-fn)]
+    (is (some? restore-fn))
+    (when restore-fn
+      (with-redefs [platform/local-storage-get (fn [key]
+                                                 (case key
+                                                   "hyperopen:trading-settings:v1"
+                                                   "{\"fill-alerts-enabled?\":true,\"animate-orderbook?\":true,\"show-fill-markers?\":false}"
+                                                   nil))]
+        (restore-fn store)
+        (is (= false (get-in @store [:trading-settings :confirm-open-orders?])))
+        (is (= false (get-in @store [:trading-settings :confirm-close-position?])))))))
+
 (deftest restore-trading-settings-malformed-storage-falls-back-safely-test
   (let [store (atom {:trading-settings {:fill-alerts-enabled? false}})
         restore-fn (restore-trading-settings-fn)]