Version 2.2.5

  - New Feature #19: Automatic linting is now done using Github Actions. Fixed many linting errors
  - New Feature #20: Added Molecule test scenarios in Pythia
  - New Feature #21: You can now specify additional runInstaller parameters by using the runinstaller_parameters variable
  - Fixed #23: Pythia now uses dynamic generated variable role_path when working with templates and files.

Author: thedatabaseme

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,7 +2,7 @@
 name: Bug report
 about: Create a report to help us improve
 title: "[BUG]"
-labels: ''
+labels: 'bug'
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,8 +1,8 @@
 ---
 name: Feature request
 about: Suggest an idea for this project
-title: ''
-labels: ''
+title: '[FEATURE]'
+labels: 'enhancement'
 assignees: ''
 
 ---

.github/workflows/ansible_lint.yml

@@ -0,0 +1,31 @@
+name: Ansible Lint  # feel free to pick your own name
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    # Important: This sets up your GITHUB_WORKSPACE environment variable
+    - uses: actions/checkout@v2
+
+    - name: Lint Ansible Playbook
+      # replace "master" with any valid ref
+      uses: ansible/ansible-lint-action@master
+      with:
+        # [required]
+        # Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
+        # or valid Ansible directories according to the Ansible role
+        # directory structure.
+        # If you want to lint multiple ansible files, use the following syntax
+        # targets: |
+        #   playbook_1.yml
+        #   playbook_2.yml
+        targets: |
+          pythia.yml
+          roles/pythia/
+        override-deps: |
+          ansible-lint==5.3.2
+        args: "-p -x command-instead-of-shell -x risky-shell-pipe -x no-jinja-when"

Changelog.txt

@@ -1,5 +1,11 @@
 Changelog of Pythia:
 
+Version 2.2.5
+  - New Feature #19: Automatic linting is now done using Github Actions. Fixed many (really many) linting errors and refactored lots of code
+  - New Feature #20: Added Molecule test scenarios in Pythia
+  - New Feature #21: You can now specify additional runInstaller parameters by using the runinstaller_parameters variable
+  - Fixed #23: Pythia now uses dynamic generated variable role_path when working with templates and files.
+
 Version 2.2.0
   - New Feature #17: Pythia now supports Oracle Database 21c as well as Multitenant / Container Databases
 

README.md

@@ -32,7 +32,7 @@ You can adapt Pythia to your needs by configure variables when running the Playb
 Requirements
 ------------
 
-Pythia requires you to run Ansible 2.7 or higher. The Oracle Software you want to install / configure by Pythia has to be located on a "Staging Area" mounted on the Control Server. Keep in Mind, that you need to licence Oracle Software separately!
+Pythia requires you to run Ansible 2.9 or higher. The Oracle Software you want to install / configure by Pythia has to be located on a "Staging Area" mounted on the Control Server. Keep in Mind, that you need to licence Oracle Software separately!
 
 Installation and Configuration
 ------------------------------

docs/01_GENERAL.md

@@ -22,7 +22,9 @@ Pythia is based on working with (Ansible) TAGs. When creating the command to run
   - duplicate: Specifies, that you want to duplicate a Source Database to a Target Database. Uses RMAN duplicate from active Database. You need to specify the duplicate_source_host, duplicate_target_host, duplicate_source_sid and duplicate_target_sid Variable. As HOSTS you need to specify the Target Host.
   - upgrade: Specifies that you want to upgrade a Database to a new Version. You need to specify the Variables oracle_source_version, oracle_target_version, oracle_sid and upgrade_mode when starting the Playbook with the "upgrade" tag.
 
+## Stage Directory
 
+Some tasks of Pythia relate on a so called "local stage directory". In this directory, Pythia searches for the software archives of the Oracle Database. The location of the stage directory is controlled by the variable `local_stage_directory` under `vars/main.yml`. You have to be aware, that Pythia searches for this directory on the Ansible Controlhost. By default, the location is `/mnt/oracle_stage`. You still can control the specific location of a software archive in the `rdbms_dict.yml` and `patch_dict.yml`. But the location can only be underneath the `local_stage_directory`.
 ## Extra Variables
 
 Beside from specifying a TAG, you need to provide at least these Variable (regardless of which TAG you have specified). You may specify the HOSTS Variable directly in the Playbook, as an Extra Variable or in your Inventory. In these Instructions, we will always hand them over as Extra Variables.

docs/02_INSTALL_RDBMS.md

@@ -32,6 +32,11 @@ Please also check the `vars/rdbms_dict.yml` and set the following Variables as y
 |space_needed_gb|Space approximately in GB for installing the RDBMS. Respects,<br> that there is probably a Patch installed on top|
 |desc|Description of the RDBMS|
 
+### Optional Variables
+
+| Variable Name | Description              | Default Value |
+|---------------|--------------------------|---------------|
+|runinstaller_parameters|Additional runinstaller parameters during installation<br>of Oracle software. For example `-ignoreInternalDriverError`.|`NONE`|
 ## Examples
 
 Example: Install Oracle RDBMS with Version 18c as Standard Edition 2 on Host "ansibletest":

docs/99_MOLECULE.md

@@ -0,0 +1,32 @@
+# General Informations
+Pythia has implemented some Molecule test scenarios. This section describes which scenarios there are and how to run them.
+
+
+# Prerequisites
+
+In order to run Molecule tests for Pythia, there are some prerequisites, that need to be fullfilled.
+
+  - A Linux Host / VM (e.G. Ubuntu 20.04)
+  - Python3 with pip installed
+  - Docker installed (see (here)[https://docs.docker.com/engine/install/ubuntu/])
+  - Molecule with Docker Module installed (see (here)[https://thedatabaseme.de/2022/01/17/automated-testing-your-ansible-role-with-molecule-and-github-actions/])
+  - This repository cloned on the Host / VM you prepared
+  - A `local_stage_directory` is attached to the Host / VM with Oracle Database software in version 21c.
+
+
+# Molecule scenarios
+
+The following scenarios are implemented as Molecule tests:
+
+  - `install_rdbms`: Installs an Oracle DB RDBMS in version 21c.
+  - `install_db`: Installs an Oracle DB on one an existing RDBMS. Be aware, this will not work on an "empty" Docker Image without an Oracle Database installed.
+  - `install_patch`: Installs an Oracle DB patch on one or many existing databases. Be aware, this will not work on an "empty" Docker Image without an Oracle Database installed.
+  - `install_rdbms_db_patch`: This will do everything and is also the `default` Molecule test scenario.
+
+# Run a Molecule test
+
+To run a Molecule test, head to the roles root directory (`roles/pythia/`) and run molecule with the wanted scenario. Here is an example:
+
+    - molecule test -s install_rdbms_db_patch
+
+If you don't want to get the container destroyed after a test run, add the `--destroy=never` parameter to your `molecule` command.

pythia.yml

@@ -1,5 +1,6 @@
 - hosts: "{{ HOSTS | default('all') }}"
+  become: true
   become_user: root
-  
+
   roles:
    - roles/pythia

roles/pythia/.yamllint

@@ -0,0 +1,33 @@
+---
+# Based on ansible-lint config
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+    level: error
+  brackets:
+    max-spaces-inside: 1
+    level: error
+  colons:
+    max-spaces-after: -1
+    level: error
+  commas:
+    max-spaces-after: -1
+    level: error
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  empty-lines:
+    max: 3
+    level: error
+  hyphens:
+    level: error
+  indentation: disable
+  key-duplicates: enable
+  line-length: disable
+  new-line-at-end-of-file: disable
+  new-lines:
+    type: unix
+  trailing-spaces: disable
+  truthy: disable