Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to WebDriver protocol's built-in implicit wait mechanism #69

Closed
tristanlabelle opened this issue Aug 27, 2023 · 1 comment
Closed

Migrate to WebDriver protocol's built-in implicit wait mechanism #69

tristanlabelle opened this issue Aug 27, 2023 · 1 comment

Comments

@tristanlabelle
Copy link
Contributor

tristanlabelle commented Aug 27, 2023 •
edited
Loading

We reimplemented implicit waiting but the WebDriver protocol actually provides this functionality:

https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidtimeoutsimplicit_wait
https://www.w3.org/TR/webdriver1/#set-timeouts

We should also remove the 1-second default timeout since it is arbitrary. WebDriver rather defaults to no implicit wait and puts the burden on the library user to specify any magic number they want.
@tristanlabelle tristanlabelle mentioned this issue Sep 3, 2023
Merged
@tristanlabelle
Copy link
Contributor Author

Done as of #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tristanlabelle