Merge pull request #3 from theZieger/dev

fixes problems in dev environments and string compat

Author: Eric Zieger

README.md

@@ -1,4 +1,4 @@
-# cookiejs v0.4.0
+# cookiejs v0.4.1
 
 > Set, get and remove cookies.
 
@@ -26,7 +26,7 @@ cookiejs.set(
     'captainObvious', 
     'Thank you Captain Obvious, you just saved my life.',
     {
-        domain: '.eric-zieger.de',                   // default: '.domain.tld',
+        domain: '.eric-zieger.de',                   // default: 'subdomain.current-domain.tld',
         path: '/the-adventures-of-captain-obvious/', // default: '/',
         expires: sYourUTCString,                     // default: undefined (session cookie)
         max-age: 60 // max-age-in-seconds,           // default: undefined

cookiejs.js

@@ -16,17 +16,6 @@
      */
     var cookiejs = {};
 
-    /**
-     * gets the current document.domain and returns .DOMAIN.TLD to make cookie accessable over all subdomains
-     * 
-     * @private
-     * 
-     * @returns {String}    representation of ".DOMAIN.TLD" of document.domain
-     */
-    var getCookieDomain = function() {
-        return '.' + document.domain.split('.').slice(-2).join('.');
-    };
-
     /**
      * sets or overwrites a cookie
      * 
@@ -39,24 +28,17 @@
     cookiejs.set = function(sCookieName, sValue, oAttributes) {
         var sAttributes = '';
 
-        oAttributes = oAttributes || {
-            domain: '; domain=' + getCookieDomain(),
-            path: '; path=/'
-        };
-
-        if (oAttributes['domain'] === undefined) {
-            sAttributes += '; domain=' + getCookieDomain();
-        }
+        oAttributes = oAttributes || {};
 
-        if (oAttributes['path'] === undefined) {
+        if (typeof oAttributes.path !== 'string') {
             sAttributes += '; path=/';
         }
 
         Object.keys(oAttributes).forEach(function(sAttributeName) {
             sAttributes += ';' + sAttributeName + '=' + oAttributes[sAttributeName];
-        });
+        });    
 
-        document.cookie = sCookieName + '=' + sValue + sAttributes;
+        document.cookie = encodeURIComponent(sCookieName) + '=' + encodeURIComponent(sValue) + sAttributes;
     };
 
     /**
@@ -79,8 +61,8 @@
 
         for (var i = aCookies.length - 1; i >= 0; i--) {
             aCookie = aCookies[i].split('=');
-            if (aCookie[0] === sCookieName) {
-                gCookieValue = aCookie[1];
+            if (decodeURIComponent(aCookie[0]) === sCookieName) {
+                gCookieValue = decodeURIComponent(aCookie[1]);
             }
         }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cookiejs.js",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Set, get and remove cookies.",
   "main": "cookiejs.js",
   "scripts": {