Skip to content

Commit e2ad343

Browse files
committed
wallet: remove unused SignatureData instances in spkm's FillPSBT methods
These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed.
1 parent 651fb03 commit e2ad343

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/wallet/scriptpubkeyman.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -652,8 +652,6 @@ TransactionError LegacyScriptPubKeyMan::FillPSBT(PartiallySignedTransaction& psb
652652
// There's no UTXO so we can just skip this now
653653
continue;
654654
}
655-
SignatureData sigdata;
656-
input.FillSignatureData(sigdata);
657655
SignPSBTInput(HidingSigningProvider(this, !sign, !bip32derivs), psbtx, i, &txdata, sighash_type, nullptr, finalize);
658656

659657
bool signed_one = PSBTInputSigned(input);
@@ -2520,8 +2518,6 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction&
25202518
// There's no UTXO so we can just skip this now
25212519
continue;
25222520
}
2523-
SignatureData sigdata;
2524-
input.FillSignatureData(sigdata);
25252521

25262522
std::unique_ptr<FlatSigningProvider> keys = std::make_unique<FlatSigningProvider>();
25272523
std::unique_ptr<FlatSigningProvider> script_keys = GetSigningProvider(script, /*include_private=*/sign);

0 commit comments

Comments
 (0)