"Has Flea" still inconsistent

[Reithan]

"Has Flea: False" now excludes flea pricing from components of a craft, but the end product still seems to use the flea price

[Razzmatazzz]

These aren't the flea prices; these are the amounts you'd get for selling these items to traders. The theory being that if a player doesn't have the flea, an item is "worth" the amount they'd get if sold to a trader. However, the icon should probably be different to differentiate it from "buy from trader" prices.

[Reithan]

No, the sell to trader prices are clear, I'm talking about the price under the result product (The power cord), it still says
"39 000 R @ Flea Market"

[Razzmatazzz]

Oh yeah I see that now. Crafts will basically never be profitable before the flea market, though. The whole question of how much ingredients "cost" and how much crafted items are worth is really weird in that context.

[GrantBirki]

@Reithan I see a pull request #128 was linked in this PR and now closed. Did this resolve the issue or is this still a problem? If so, I can label accordingly or close if it is resolved

[Reithan]

That's another similar issue, rather than a pull request it looks like?
This issue is...not cut-and-dry I think, as @Razzmatazzz was pointing out - I don't know what the best answer to this one is.
As he pointed out - if we do what the 'obvious' thing here is and show the trader value for crafts if you have no flea, then nothing will be worth crafting.
But, you could assume that most people know that, and would likely be crafting things they plan to sell once they get flea unlocked? I don't know

[Razzmatazzz]

Yeah, it's a complicated issue. Arguably, it's also not great to show a "value" of craft ingredients equal to the sell-to-trader price either because those items may be worth considerably more once the user unlocks the flea. So a craft that looks "profitable" when compared to selling the ingredients to traders and eventually selling the finished item on the flea may actually be "unprofitable" because the user could have made more by just waiting and selling the ingredients themselves on the flea.

ETA: I think the crafting profit calculator is basically just not helpful before a user has the flea unlocked.

[Reithan]

Perhaps we could just add a warning in like big red letters at the top if you have flea toggled off?
But still show all the non-flea numbers.

[GrantBirki]

Is this still an issue @Reithan?

cc: @Razzmatazzz

[Reithan]

@GrantBirki seems to be "correctly" using trader prices, though, as @Razzmatazzz warned, we may want to show some kind of warning to the user while this is the case, so they don't "accidentally" sell or craft with a bunch of shit before they unlock flea that would have been worth a lot more if they'd waited. But caveat emptor, I suppose.