Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation key for lent out books #133

Closed
ChristianGruen opened this issue Mar 16, 2025 · 4 comments
Closed

Translation key for lent out books #133

ChristianGruen opened this issue Mar 16, 2025 · 4 comments

Comments

@ChristianGruen
Copy link
Contributor

A minor (minor) observation: The key…

https://hosted.weblate.org/translate/nevertoomanybooks/main/en/?checksum=a59d068678449b63&q=option_bob_filter_lend_out_yes

…should possibly be option_bob_filter_lent_out_yes.

The same may apply to similar keys.

@tfonteyn
Copy link
Owner

https://www.oxfordlearnersdictionaries.com/definition/english/lend

although I'm sure there can be other spelling mistakes in keys, but well... who cares :)

@ChristianGruen
Copy link
Contributor Author

https://www.oxfordlearnersdictionaries.com/definition/english/lend

I guessed the text was meant to indicate past tense (in the sense of “these books have been lent out”). Another example is “Lend book is returned”, which I guess should be “Lent book is returned” (in analogy with the German variant “Geliehenes Buch ist zurück”).

although I'm sure there can be other spelling mistakes in keys, but well... who cares :)

…just true. I thought about changing only the English strings, but I first wanted to ask what you think.

@tfonteyn
Copy link
Owner

sorry, misunderstanding:

spelling mistakes in keys
I meant/thought actual key names -> who cares :)

spelling mistakes in strings
Certainly care about those.

Lend
no, I did mean current tense.

changing only the English strings,
feel free to point any out of course, always welcome, but leave the correction of English to myself

@ChristianGruen
Copy link
Contributor Author

Lend
no, I did mean current tense.

I feel bad to be pushy, but I still believe that “Lend book is returned” is wrong – or I wonder what it is supposed to mean?

feel free to point any out of course, always welcome, but leave the correction of English to myself

Promised!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants