Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid View: scrolling to correct offset #120

Closed
ChristianGruen opened this issue Mar 4, 2025 · 5 comments
Closed

Grid View: scrolling to correct offset #120

ChristianGruen opened this issue Mar 4, 2025 · 5 comments
Assignees
Labels
bug Something isn't working Confirmed for next release This issue has been implemented/fixed and will be in the next release

Comments

@ChristianGruen
Copy link
Contributor

ChristianGruen commented Mar 4, 2025

Maybe this one is challenging to fix:

When I have many books listed in the Grid View, when I open the detail view and when I go back, the viewport changes (I see other books than before). Everything works fine in the List View.

PS: This also happens when switching to another Android app and back.

@tfonteyn
Copy link
Owner

tfonteyn commented Mar 5, 2025

Maybe this one is challenging to fix:

it is... it's been a trial and error for a long time now. I know of at least 2 other places in the code where this is not working very well.

@tfonteyn tfonteyn added the bug Something isn't working label Mar 6, 2025
@tfonteyn
Copy link
Owner

improvements coming in next release.

Keeping it short:

  • covers are loaded asynchronously (as - sigh - per google recommendation) and the problem is that the view scrolls to the correct, then loads covers, which pushes the correct position down
  • solution applied: scroll twice to the same location.

every single time you use a google api ... you end up applying workarounds for unexpected error / side-effects... android is a mess...

bottom-line: it will be better, but probably not perfect... oh well...

@tfonteyn tfonteyn added the Confirmed for next release This issue has been implemented/fixed and will be in the next release label Mar 13, 2025
@ChristianGruen
Copy link
Contributor Author

android is a mess...

Good to read that (I didn’t dare say it).

@tfonteyn
Copy link
Owner

it's well recognised as soon as you get on the community websites... but given that iPhone is the single alternative 👎

They deprecate api's, because they are broken, and replace them with new broken ones... instead of actually fixing the original.

Here's the latest bug I ran into:

public static PackageInfoWrapper createWithSignatures(@NonNull final Context context) {

old android, use GET_SIGNATURES
new android: GET_SIGNING_CERTIFICATES
oops, bug in new android... you now need to use BOTH... brilliant....

it's very demotivating

@tfonteyn tfonteyn self-assigned this Mar 16, 2025
@tfonteyn
Copy link
Owner

here you go 7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Confirmed for next release This issue has been implemented/fixed and will be in the next release
Projects
None yet
Development

No branches or pull requests

2 participants