Skip to content

use rerender props in wrapper #1284

Open

Description

@jjoselv

Describe the feature you'd like:

I would like to be able to test a re-render with a different wrapper.
The use case is to ensure that returned callbacks of the tested hook are changed when a new wrapper is used.

Mimic what was added in the testing-library/react-hooks-testing-library in testing-library/react-hooks-testing-library#381

Additionally, update the types of wrapper.

Suggested implementation:

I can't manage to modify pure.js to convey this.

Describe alternatives you've considered:


Teachability, Documentation, Adoption, Migration Strategy:


Activity

  1. eps1lon commented on Mar 9, 2024

    @eps1lon
    Member

    It should be a different option. It's just confusing to pass the same props to both the hook and the wrapper component. Especially from a type perspective this is a nightmare.

    The requested API is especially odd since we don't seem to need it for component testing. I'm inclined to recommend to people to write a test component instead and test that with render. renderHook was really just a convenience wrapper for the 90% not a 1st class testing API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions