test: fix flaky time-based test

Author: tversteeg

testcontainers/tests/async_runner.rs

@@ -272,17 +272,17 @@ async fn async_copy_files_to_container() -> anyhow::Result<()> {
 async fn async_container_exit_code() -> anyhow::Result<()> {
     let _ = pretty_env_logger::try_init();
 
-    // Container that should run for 1 second and exit with a specific doe
-    let container = GenericImage::new("alpine", "latest")
-        .with_cmd(vec!["/bin/sh", "-c", "sleep 1 && exit 4"])
+    // Container that should run until manually quit
+    let container = GenericImage::new("simple_web_server", "latest")
+        .with_wait_for(WaitFor::message_on_stdout("server is ready"))
         .start()
         .await?;
 
     assert_eq!(container.exit_code().await?, None);
 
-    // After waiting for two seconds it shouldn't be running anymore
-    tokio::time::sleep(Duration::from_secs(2)).await;
-    assert_eq!(container.exit_code().await?, Some(4));
+    container.stop().await?;
+
+    assert_eq!(container.exit_code().await?, Some(0));
 
     Ok(())
 }

testcontainers/tests/sync_runner.rs

@@ -292,16 +292,16 @@ fn sync_copy_files_to_container() -> anyhow::Result<()> {
 fn sync_container_exit_code() -> anyhow::Result<()> {
     let _ = pretty_env_logger::try_init();
 
-    // Container that should run for 1 second and exit with a specific doe
-    let container = GenericImage::new("alpine", "latest")
-        .with_cmd(vec!["/bin/sh", "-c", "sleep 1 && exit 4"])
+    // Container that should run until manually quit
+    let container = GenericImage::new("simple_web_server", "latest")
+        .with_wait_for(WaitFor::message_on_stdout("server is ready"))
         .start()?;
 
     assert_eq!(container.exit_code()?, None);
 
-    // After waiting for two seconds it shouldn't be running anymore
-    std::thread::sleep(Duration::from_secs(2));
-    assert_eq!(container.exit_code()?, Some(4));
+    container.stop()?;
+
+    assert_eq!(container.exit_code()?, Some(0));
 
     Ok(())
 }