[Bug]: LocalStack runs in legacy mode when it shouldn't

[myroslavlisniak]

Module

LocalStack

Testcontainers version

1.18.1

Using the latest Testcontainers version?

No

Host OS

MacOs

Host Arch

ARM

Docker version

Client:
 Cloud integration: v1.0.35
 Version:           24.0.2
 API version:       1.43
 Go version:        go1.20.4
 Git commit:        cb74dfc
 Built:             Thu May 25 21:51:16 2023
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.21.1 (114176)
 Engine:
  Version:          24.0.2
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       659604f
  Built:            Thu May 25 21:50:59 2023
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

What happened?

LocalStack container runs in legacy mode, when docker image use sha256 versioning

LocalStackContainer localStack = new LocalStackContainer(
            "localstack/localstack:1.4@sha256:4a966e42eff4bbeec44afe13c2d24a67954742b191caae7c15e56186cc0b9ed8")
            .withServices(LocalStackContainer.Service.DYNAMODB);

Most probably version comparison works incorrect in this case

Relevant log output

No response

Additional Information

Current workaround is to use LocalStackContainer(DockerImageName dockerImageName, boolean legacyMode) but it's deprecated

[alexrashed]

I just looked into this a bit, and it turns out that this error is not directly reproducible anymore:

• If the container is created by using the version parameter of the constructor directly, it correctly detects version 1.4:

  new LocalStackContainer("1.4@sha256:4a966e42eff4bbeec44afe13c2d24a67954742b191caae7c15e56186cc0b9ed8")
  

  This is because it directly assumes these versions to be tag versions:

  testcontainers-java/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java

  Line 97 in 6658a2c

  this(DEFAULT_IMAGE_NAME.withTag(version));

  
  Afterwards the version is correctly detected.
• However, if you use the DockerImageName, this is still not working correcly:

  new LocalStackContainer(DockerImageName.parse("localstack/localstack:1.4@sha256:4a966e42eff4bbeec44afe13c2d24a67954742b191caae7c15e56186cc0b9ed8").asCompatibleSubstituteFor("localstack/localstack")
  

  This is because here the sha versioning has precedence over the tags and the tag is actually completely removed:
  

  testcontainers-java/core/src/main/java/org/testcontainers/utility/DockerImageName.java

  Line 89 in 6658a2c

  if (remoteName.contains("@sha256:")) {

  
  This in combination with the default fallback to useLegacyMode=true results in the issue.

I think the root of this issue is that the legacy mode is still the default fallback.
In the meantime, LocalStack 3.5 is about to be released, and the legacy handling is only relevant for versions before 0.11 (which was released 4 years ago on the 4th of April 2020).

I would propose to fix this issue by changing the default to useLegacyMode=false.
I would be happy to file a PR, but I would love to get some insights on this by a maintainer (f.e. @eddumelendez 😛 ?) first.