From 8528d77e42c2aff74d86fabfa0b867ad50069249 Mon Sep 17 00:00:00 2001 From: Laurent Goderre Date: Mon, 3 Nov 2025 10:36:54 -0500 Subject: [PATCH 1/2] add auth test for the default registry --- docker_auth_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docker_auth_test.go b/docker_auth_test.go index 74042fc573..6fbd054bed 100644 --- a/docker_auth_test.go +++ b/docker_auth_test.go @@ -123,6 +123,20 @@ func TestDockerImageAuth(t *testing.T) { require.Equal(t, base64, cfg.Auth) }) + t.Run("match the default registry authentication by host", func(t *testing.T) { + imageReg := "docker.io" + imagePath := "/my/image:latest" + reg := defaultRegistry(context.Background()) + base64 := setAuthConfig(t, reg, "gopher", "secret") + + registry, cfg, err := DockerImageAuth(context.Background(), imageReg+imagePath) + require.NoError(t, err) + require.Equal(t, reg, registry) + require.Equal(t, "gopher", cfg.Username) + require.Equal(t, "secret", cfg.Password) + require.Equal(t, base64, cfg.Auth) + }) + t.Run("fail to match registry authentication due to invalid host", func(t *testing.T) { imageReg := "example-auth.com" imagePath := "/my/image:latest" From df49f93fe6e5346fba80a0254de28d49955175eb Mon Sep 17 00:00:00 2001 From: Laurent Goderre Date: Mon, 3 Nov 2025 11:09:33 -0500 Subject: [PATCH 2/2] fix: docker auth for docker.io images --- docker_auth.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docker_auth.go b/docker_auth.go index 58b3ef2637..25b8fe6d85 100644 --- a/docker_auth.go +++ b/docker_auth.go @@ -42,6 +42,10 @@ func dockerImageAuth(ctx context.Context, image string, configs map[string]regis defaultRegistry := defaultRegistryFn(ctx) reg := core.ExtractRegistry(image, defaultRegistry) + if reg == "docker.io" { + reg = defaultRegistry + } + if cfg, ok := getRegistryAuth(reg, configs); ok { return reg, cfg, nil }