Improve MessageSinkLogger and TestOutputLogger implementatinos

* Use a NullScope object
* Check for logLevel != LogLevel.None

Author: 0xced

src/Testcontainers.Xunit/MessageSinkLogger.cs

@@ -1,20 +1,16 @@
 namespace Testcontainers.Xunit;
 
-internal sealed class MessageSinkLogger(IMessageSink messageSink) : ILogger, IDisposable
+internal sealed class MessageSinkLogger(IMessageSink messageSink) : ILogger
 {
     public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)
     {
         var message = exception == null ? formatter(state, null) : $"{formatter(state, exception)}{Environment.NewLine}{exception}";
         messageSink.OnMessage(new DiagnosticMessage($"[testcontainers.org] {message}"));
     }
 
-    public bool IsEnabled(LogLevel logLevel) => true;
+    public bool IsEnabled(LogLevel logLevel) => logLevel != LogLevel.None;
 
-    public IDisposable BeginScope<TState>(TState state) => this;
-
-    public void Dispose()
-    {
-    }
+    public IDisposable BeginScope<TState>(TState state) => new NullScope();
 
     /// <returns>
     /// The hash code of the underlying message sink, because <see cref="DotNet.Testcontainers.Clients.DockerApiClient.LogContainerRuntimeInfoAsync"/>

src/Testcontainers.Xunit/NullScope.cs

@@ -0,0 +1,9 @@
+namespace Testcontainers.Xunit
+{
+    internal sealed class NullScope : IDisposable
+    {
+        public void Dispose()
+        {
+        }
+    }
+}

src/Testcontainers.Xunit/TestOutputLogger.cs

@@ -1,6 +1,6 @@
 namespace Testcontainers.Xunit;
 
-internal sealed class TestOutputLogger(ITestOutputHelper testOutputHelper) : ILogger, IDisposable
+internal sealed class TestOutputLogger(ITestOutputHelper testOutputHelper) : ILogger
 {
     private readonly Stopwatch _stopwatch = Stopwatch.StartNew();
 
@@ -13,11 +13,7 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
         }
     }
 
-    public bool IsEnabled(LogLevel logLevel) => true;
+    public bool IsEnabled(LogLevel logLevel) => logLevel != LogLevel.None;
 
-    public IDisposable BeginScope<TState>(TState state) => this;
-
-    public void Dispose()
-    {
-    }
+    public IDisposable BeginScope<TState>(TState state) => new NullScope();
 }