Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.create(undefined) should throw an exception #717

Open
rwaldron opened this issue Mar 5, 2015 · 0 comments
Open

Object.create(undefined) should throw an exception #717

rwaldron opened this issue Mar 5, 2015 · 0 comments

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Mar 5, 2015

#716 motivated me to check this. The existing issue re: null and undefined are treated as the same by Lua, results in wrong semantics for special cases:

// this creates a null proto object
console.log(Object.create(null));

// this should throw an exception
console.log(Object.create(undefined));
rwaldron at nova in ~/codez/javascript
$ ~/clonez/runtime/out/Release/colony object.create.js
{
}
{
}
rwaldron at nova in ~/codez/javascript
$ node object.create.js
{}

/Users/rwaldron/codez/javascript/object.create.js:2
console.log(Object.create(undefined));
                   ^
TypeError: Object prototype may only be an Object or null
    at Function.create (native)
    at Object.<anonymous> (/Users/rwaldron/codez/javascript/object.create.js:2:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:929:3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant