Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gps_get_date() actually calls gps_get_time() #141

Closed
srl295 opened this issue Jul 7, 2015 · 9 comments · Fixed by #142
Closed

gps_get_date() actually calls gps_get_time() #141

srl295 opened this issue Jul 7, 2015 · 9 comments · Fixed by #142
Assignees

Comments

@srl295
Copy link
Contributor

srl295 commented Jul 7, 2015

https://github.com/tessel/t1-firmware/blob/master/src/hw/l_hw.c#L735

Shouldn't this be gps_get_date()? Looks like a copy and paste error.

> var hw = process.binding('hw'); [ hw.gps_get_time(), hw.gps_get_date() ]
[ 213053.119, 213053.119 ]

Related: tessel/gps-a2235h#3

@srl295 srl295 changed the title gps_get_time actuall calls gps_get_date gps_get_date() actually calls gps_get_time() Jul 7, 2015
@srl295
Copy link
Contributor Author

srl295 commented Jul 9, 2015

btw the above fix did seem to work for me, except that somehow the time and datestamps became integer (no fractional seconds).

@johnnyman727
Copy link
Contributor

@srl295 thanks for catching this! Do you think you'll be able to open a PR and roll that change in?

@srl295
Copy link
Contributor Author

srl295 commented Aug 8, 2015

@johnnyman727 yes i will open a PR!

srl295 added a commit to srl295/t1-firmware that referenced this issue Aug 8, 2015
@yetzt
Copy link

yetzt commented Feb 5, 2016

after merging the fix, when will there be a new firmware to update my tessel?

@johnnyman727
Copy link
Contributor

@yetzt I will try to put out a new release this week. As you may have noticed, nobody else is actively working on T1 so the process of putting out a new build is a bit of a forgotten art. I also want to change one API that is incompatible with T2 so we may be able to kill two birds with one stone.

@yetzt
Copy link

yetzt commented Feb 10, 2016

@johnnyman727 i noticed. thanks for caring! <3

@johnnyman727
Copy link
Contributor

@yetzt new build should be available now (0.2.0)

@yetzt
Copy link

yetzt commented Feb 18, 2016

\o/ <3 thanks @johnnyman727

@srl295
Copy link
Contributor Author

srl295 commented Feb 18, 2016

Ooh- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants