Skip to content

Commit a4b1bdd

Browse files
committed
Use reified generics instead of java classes
1 parent 19fde8f commit a4b1bdd

11 files changed

Lines changed: 22 additions & 14 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.6.3
1+
version=0.6.4

minecraft-codev-core/src/main/kotlin/net/msrandom/minecraftcodev/core/ResolutionRule.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package net.msrandom.minecraftcodev.core
33
import net.msrandom.minecraftcodev.core.utils.zipFileSystem
44
import org.gradle.api.model.ObjectFactory
55
import org.gradle.api.provider.ListProperty
6+
import org.gradle.kotlin.dsl.listProperty
67
import java.nio.file.FileSystem
78
import java.nio.file.Path
89

@@ -62,13 +63,13 @@ abstract class ZipResolutionRuleHandler<T : ResolutionData<*>, U : ZipResolution
6263

6364
@Suppress("UNCHECKED_CAST")
6465
fun <T : ResolutionData<*>> ObjectFactory.zipResolutionRules() =
65-
listProperty(ZipResolutionRule::class.java) as ListProperty<ZipResolutionRule<T>>
66+
listProperty<ZipResolutionRule<T>>()
6667

6768
@Suppress("UNCHECKED_CAST")
6869
fun <T : ResolutionData<*>> ObjectFactory.resolutionRules(
6970
zipResolutionRules: ListProperty<ZipResolutionRule<T>>,
7071
): ListProperty<ResolutionRule<T>> {
71-
val rules = listProperty(ResolutionRule::class.java) as ListProperty<ResolutionRule<T>>
72+
val rules = listProperty<ResolutionRule<T>>()
7273

7374
rules.add { path, extension, data ->
7475
handleZipRules(zipResolutionRules.get(), path, extension, data)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.6.8
1+
version=0.6.9

minecraft-codev-fabric/src/main/kotlin/net/msrandom/minecraftcodev/fabric/runs/FabricRunsIntegration.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ import net.msrandom.minecraftcodev.runs.RunConfigurationDefaultsContainer
66
import net.msrandom.minecraftcodev.runs.RunsContainer
77
import org.gradle.api.Project
88
import org.gradle.kotlin.dsl.create
9+
import org.gradle.kotlin.dsl.withType
910

1011
fun Project.setupFabricRunsIntegration() {
11-
plugins.withType(MinecraftCodevRunsPlugin::class.java) {
12+
plugins.withType<MinecraftCodevRunsPlugin<*>> {
1213
val defaults = extension<RunsContainer>().extension<RunConfigurationDefaultsContainer>()
1314

1415
defaults.extensions.create("fabric", FabricRunsDefaultsContainer::class, defaults)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.6.7
1+
version=0.6.8

minecraft-codev-forge/src/main/kotlin/net/msrandom/minecraftcodev/forge/runs/ForgeRunsDefaultsContainer.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ import org.gradle.api.file.FileCollection
2424
import org.gradle.api.provider.Property
2525
import org.gradle.api.provider.Provider
2626
import org.gradle.api.tasks.*
27+
import org.gradle.kotlin.dsl.listProperty
28+
import org.gradle.kotlin.dsl.mapProperty
2729
import org.gradle.kotlin.dsl.newInstance
2830
import java.io.File
2931
import kotlin.io.path.readText
@@ -155,7 +157,7 @@ open class ForgeRunsDefaultsContainer(
155157
}
156158

157159
beforeRun.addAll(configProvider.flatMap {
158-
val list = project.objects.listProperty(Task::class.java)
160+
val list = project.objects.listProperty<Task>()
159161

160162
val hasAssets = it.getRun().args.contains("{assets_root}") ||
161163
it.getRun().env.containsValue("{assets_root}")
@@ -202,7 +204,7 @@ open class ForgeRunsDefaultsContainer(
202204

203205
environment.putAll(
204206
zipped.flatMap { (manifest, userdevConfig) ->
205-
project.objects.mapProperty(String::class.java, String::class.java).apply {
207+
project.objects.mapProperty<String, String>().apply {
206208
for ((key, value) in userdevConfig.getRun().env) {
207209
val argument =
208210
if (value.startsWith('$')) {

minecraft-codev-forge/src/main/kotlin/net/msrandom/minecraftcodev/forge/runs/setupForgeRunsIntegration.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ import net.msrandom.minecraftcodev.runs.RunConfigurationDefaultsContainer
66
import net.msrandom.minecraftcodev.runs.RunsContainer
77
import org.gradle.api.Project
88
import org.gradle.kotlin.dsl.create
9+
import org.gradle.kotlin.dsl.withType
910

1011
internal fun Project.setupForgeRunsIntegration() {
11-
plugins.withType(MinecraftCodevRunsPlugin::class.java) {
12+
plugins.withType<MinecraftCodevRunsPlugin<*>>() {
1213
val defaults = extension<RunsContainer>().extension<RunConfigurationDefaultsContainer>()
1314

1415
defaults.extensions.create("forge", ForgeRunsDefaultsContainer::class, defaults)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=0.6.6
1+
version=0.6.7

minecraft-codev-runs/src/main/kotlin/net/msrandom/minecraftcodev/runs/MinecraftRunConfiguration.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import org.gradle.api.provider.MapProperty
1616
import org.gradle.api.provider.Property
1717
import org.gradle.api.provider.Provider
1818
import org.gradle.api.tasks.*
19+
import org.gradle.kotlin.dsl.listProperty
1920
import org.gradle.kotlin.dsl.register
2021
import java.io.File
2122
import java.nio.file.Path
@@ -216,7 +217,7 @@ abstract class MinecraftRunConfiguration @Inject constructor(private val name: S
216217
}
217218

218219
fun compileArguments(arguments: Iterable<Any?>): ListProperty<String> =
219-
project.objects.listProperty(String::class.java).apply {
220+
project.objects.listProperty<String>().apply {
220221
for (argument in arguments) {
221222
if (argument is Provider<*>) {
222223
add(argument.map(::mapArgumentPart))

minecraft-codev-runs/src/main/kotlin/net/msrandom/minecraftcodev/runs/RunConfigurationDefaultsContainer.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import org.gradle.api.provider.Provider
1616
import org.gradle.api.tasks.Input
1717
import org.gradle.api.tasks.Nested
1818
import org.gradle.api.tasks.Optional
19+
import org.gradle.kotlin.dsl.named
1920
import java.util.jar.Attributes
2021
import java.util.jar.JarFile
2122
import java.util.jar.Manifest
@@ -33,12 +34,12 @@ abstract class RunConfigurationDefaultsContainer : ExtensionAware {
3334

3435
val extractNativesTask =
3536
sourceSet.flatMap {
36-
project.tasks.named(it.extractNativesTaskName, ExtractNatives::class.java)
37+
project.tasks.named<ExtractNatives>(it.extractNativesTaskName)
3738
}
3839

3940
val downloadAssetsTask =
4041
sourceSet.flatMap {
41-
project.tasks.named(it.downloadAssetsTaskName, DownloadAssets::class.java)
42+
project.tasks.named<DownloadAssets>(it.downloadAssetsTaskName)
4243
}
4344

4445
beforeRun.add(extractNativesTask)

0 commit comments

Comments
 (0)