Bug Description
@GoldenMidas on Discord:
hey! i think there something not right either in the wiki page or with how "parents visible" setting goes
apparently, instead of it checking whether or not dependencies are visible, it checks whether or not dependecies are completed
This may be because when recursively checking whether a quest's dependencies would be hidden, the dependencies' display status isn't respected:
|
} else if (status == QuestDisplayStatus.DEPENDENCIES_VISIBLE) { |
|
boolean visible = statuses.getBoolean(quest.key()); |
|
if (visible) { |
|
return false; |
|
} |
|
for (var dependency : quest.dependencies()) { |
|
if (shouldHide(statuses, dependency, QuestDisplayStatus.DEPENDENCIES_VISIBLE)) { |
|
return true; |
|
} |
|
} |
|
return quest.value().settings().hiddenUntil() != QuestDisplayStatus.DEPENDENCIES_VISIBLE; |
|
} |
How to Reproduce?
in non-edit mode
in edit mode
all of the quests with ingots/diamond have the "hidden until" set to "parents visible"
each one has the previous one as a dependency
(middle one -> copper -> iron -> gold -> diamond)
[...] but they only become visible once the copper one is completed
Expected Behavior
from what the wiki says, i assumed as soon as the copper one was visible, all of the following ones would be too
Version
1.1.13
Mod Loader Version
N/A
Mod Loader
N/A
Logs or additional context
No response
Code of Conduct
Bug Description
@GoldenMidas on Discord:
This may be because when recursively checking whether a quest's dependencies would be hidden, the dependencies' display status isn't respected:
Heracles/common/src/main/java/earth/terrarium/heracles/client/screens/quests/QuestsWidget.java
Lines 171 to 182 in b9a3db2
How to Reproduce?
Expected Behavior
Version
1.1.13
Mod Loader Version
N/A
Mod Loader
N/A
Logs or additional context
No response
Code of Conduct