Fix gcs_source to uris transform #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested changes
Jul 22, 2025
| for_each = var.gcs_source != null ? ["gcs_source"] : [] | ||
| content { | ||
| uris = var.gcs_source | ||
| uris = split(",", var.gcs_source) |
Member
There was a problem hiding this comment.
If a list is expected as input, it would be better to change gcs_source to a list type.
Author
There was a problem hiding this comment.
Can do, but as a note - that goes kinda against the way lists are handled elsewhere in google terraform modules, for example node_locations comma separated list in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine (right in the root readme).
I actually do prefer using a proper list by the way, just wanted to double check with you.
Member
There was a problem hiding this comment.
It escapes me why we did it that way for node_locations (maybe because node_pools were untyped) but I am leaning towards list for this case. @imrannayer @q2w any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new valkey cluster with gcs_source, we are instructed to pass a comma-separated list. However, it's not accepted by the underlying terraform resource. This PR fixes that mismatch 🙏