Skip to content

Commit 894a04d

Browse files
rohit-raoMoe Ahmadi
authored andcommitted
[ios] Disables testInputAccessoryViewNavigationButtons on iOS 11.
This test was already disabled on iOS 11 iPad, but it has started failing on iPhone as well in the iOS 11 GM build. BUG=753098 Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83 Reviewed-on: https://chromium-review.googlesource.com/664837 Commit-Queue: Rohit Rao (ping after 24h) <[email protected]> Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Olivier Robin <[email protected]> Reviewed-by: Justin Cohen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501604}(cherry picked from commit 9ca5963) Reviewed-on: https://chromium-review.googlesource.com/679294 Reviewed-by: Moe Ahmadi <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#402} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
1 parent a9f586c commit 894a04d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ios/showcase/payments/sc_payments_editor_egtest.mm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,9 @@ - (void)testInputAccessoryViewCloseButton {
209209
// navigate between the textfields.
210210
- (void)testInputAccessoryViewNavigationButtons {
211211
// TODO(crbug.com/753098): Re-enable this test on iOS 11 iPad once
212-
// grey_typeText works on iOS 11.
213-
if (base::ios::IsRunningOnIOS11OrLater() && IsIPadIdiom()) {
212+
// grey_typeText works on iOS 11. The test failes on iOS 11 iPhone as well,
213+
// but possibly for a different reason.
214+
if (base::ios::IsRunningOnIOS11OrLater()) {
214215
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS 11.");
215216
}
216217

0 commit comments

Comments
 (0)