Skip to content

Commit 9716650

Browse files
mattsoulanillemattsoulanille
authored
Switch from android 9 to 10 for tests (#7132)
1 parent 6dccb6a commit 9716650

File tree

15 files changed

+26
-26
lines changed

15 files changed

+26
-26
lines changed

‎BAZEL_MIGRATION.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ tfjs_web_test(
211211
"bs_firefox_mac",
212212
"bs_safari_mac",
213213
"bs_ios_12",
214-
"bs_android_9",
214+
"bs_android_10",
215215
"win_10_chrome",
216216
],
217217
static_files = [

‎e2e/karma.conf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,11 @@ module.exports = function(config) {
176176
os_version: '11.0',
177177
real_mobile: true
178178
},
179-
bs_android_9: {
179+
bs_android_10: {
180180
base: 'BrowserStack',
181-
device: 'Google Pixel 3 XL',
181+
device: 'Google Pixel 4 XL',
182182
os: 'android',
183-
os_version: '9.0',
183+
os_version: '10.0',
184184
real_mobile: true
185185
},
186186
win_10_chrome: {

‎e2e/script_tag_tests/tfjs-core-cpu/karma.conf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ module.exports = function(config) {
104104
os_version: '11.0',
105105
real_mobile: true
106106
},
107-
bs_android_9: {
107+
bs_android_10: {
108108
base: 'BrowserStack',
109-
device: 'Google Pixel 3 XL',
109+
device: 'Google Pixel 4 XL',
110110
os: 'android',
111-
os_version: '9.0',
111+
os_version: '10.0',
112112
real_mobile: true
113113
},
114114
win_10_chrome: {

‎e2e/script_tag_tests/tfjs/karma.conf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ module.exports = function(config) {
9696
os_version: '11.0',
9797
real_mobile: true
9898
},
99-
bs_android_9: {
99+
bs_android_10: {
100100
base: 'BrowserStack',
101-
device: 'Google Pixel 3 XL',
101+
device: 'Google Pixel 4 XL',
102102
os: 'android',
103-
os_version: '9.0',
103+
os_version: '10.0',
104104
real_mobile: true
105105
},
106106
win_10_chrome: {

‎e2e/scripts/test-ci.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ if [[ "$NIGHTLY" = true || "$RELEASE" = true ]]; then
6161

6262
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_firefox_mac --tags '$TAGS'"
6363
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_chrome_mac --tags '$TAGS'"
64-
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_android_9 --tags '$TAGS'"
64+
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_android_10 --tags '$TAGS'"
6565

6666
# Test script tag bundles
6767
node ../scripts/run_flaky.js "karma start ./script_tag_tests/tfjs-core-cpu/karma.conf.js --browserstack --browsers=bs_chrome_mac"

‎tfjs-backend-wasm/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ tfjs_web_test(
155155
"bs_safari_mac",
156156
"bs_ios_12",
157157
# TODO(mattsoulanille): Fix clipByValue on Android.
158-
# "bs_android_9",
158+
# "bs_android_10",
159159
"win_10_chrome",
160160
],
161161
static_files = [

‎tfjs-backend-webgl/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ tfjs_web_test(
108108
browsers = [
109109
"bs_chrome_mac",
110110
"bs_firefox_mac",
111-
"bs_android_9",
111+
"bs_android_10",
112112
"win_10_chrome",
113113
],
114114
headless = False,
115115
presubmit_browsers = [
116116
"bs_chrome_mac",
117-
"bs_android_9",
117+
"bs_android_10",
118118
],
119119
static_files = STATIC_FILES,
120120
)

‎tfjs-backend-webgl/scripts/test-ci.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ set -e
1919
if [ "$NIGHTLY" = true ]; then
2020
node ../scripts/run_flaky.js "yarn run-browserstack --browsers='bs_safari_mac,bs_ios_12' --testEnv webgl1"
2121
node ../scripts/run_flaky.js "yarn run-browserstack --browsers='bs_firefox_mac,bs_chrome_mac'"
22-
node ../scripts/run_flaky.js "yarn run-browserstack --browsers='win_10_chrome,bs_android_9' --testEnv webgl2"
22+
node ../scripts/run_flaky.js "yarn run-browserstack --browsers='win_10_chrome,bs_android_10' --testEnv webgl2"
2323
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_chrome_mac --testEnv webgl2 --flags '{"\""WEBGL_PACK"\"": false}'"
2424
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_chrome_mac --testEnv webgl2 --flags '{"\""WEBGL_CPU_FORWARD"\"": true}'"
2525
node ../scripts/run_flaky.js "yarn run-browserstack --browsers=bs_chrome_mac --testEnv webgl2 --flags '{"\""WEBGL_USE_SHAPES_UNIFORMS"\"": true}'"

‎tfjs-core/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ tfjs_web_test(
114114
"bs_firefox_mac",
115115
"bs_safari_mac",
116116
"bs_ios_12",
117-
"bs_android_9",
117+
"bs_android_10",
118118
"win_10_chrome",
119119
],
120120
static_files = [

‎tfjs-core/src/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ tfjs_web_test(
207207
# absolute paths in iOS, which is required for loading the worker.
208208
# https://www.browserstack.com/question/39573
209209
# "bs_ios_12",
210-
"bs_android_9",
210+
"bs_android_10",
211211
"win_10_chrome",
212212
],
213213
static_files = [
@@ -247,7 +247,7 @@ tfjs_web_test(
247247
# absolute paths in iOS, which is required for loading the worker.
248248
# https://www.browserstack.com/question/39573
249249
# "bs_ios_12",
250-
"bs_android_9",
250+
"bs_android_10",
251251
"win_10_chrome",
252252
],
253253
static_files = [

‎tfjs-layers/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ tfjs_web_test(
5252
browsers = [
5353
"bs_chrome_mac",
5454
"bs_firefox_mac",
55-
# disabled android 9 test due to training flakiness
56-
# "bs_android_9",
55+
# disabled android test due to training flakiness
56+
# "bs_android_10",
5757
"win_10_chrome",
5858
],
5959
headless = False,

‎tfjs-tfdf/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ tfjs_web_test(
108108
# TODO: Support Safari.
109109
"bs_chrome_mac",
110110
"bs_firefox_mac",
111-
"bs_android_9",
111+
"bs_android_10",
112112
"win_10_chrome",
113113
],
114114
static_files = [

‎tfjs-tflite/src/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ tfjs_web_test(
110110
# absolute paths in iOS, which is required for loading the worker.
111111
# https://www.browserstack.com/question/39573
112112
# "bs_ios_12",
113-
"bs_android_9",
113+
"bs_android_10",
114114
"win_10_chrome",
115115
],
116116
static_files = [

‎tools/karma_template.conf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ const CUSTOM_LAUNCHERS = {
5454
os_version: '12.3',
5555
real_mobile: true
5656
},
57-
bs_android_9: {
57+
bs_android_10: {
5858
base: 'BrowserStack',
59-
device: 'Google Pixel 3 XL',
59+
device: 'Google Pixel 4 XL',
6060
os: 'android',
61-
os_version: '9.0',
61+
os_version: '10.0',
6262
real_mobile: true
6363
},
6464
win_10_chrome: {

‎tools/tfjs_web_test.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def tfjs_web_test(name, ci = True, args = [], **kwargs):
125125
"bs_firefox_mac",
126126
"bs_safari_mac",
127127
"bs_ios_12",
128-
"bs_android_9",
128+
"bs_android_10",
129129
"win_10_chrome",
130130
])
131131

0 commit comments

Comments
 (0)