Load tflite and tfdf wasm files with http_archive (#7124)

tfjs-tfdf and tfjs-tflite both depend on pre-compiled WASM files. These WASM files are downloaded by scripts (i.e. curl) during the build step. This violates Bazel's hermeticity requirements because build steps should not access remote resources. This PR fixes this by downloading these WASM files using http_archive in the WORKSPACE file.

Fixes #7103

Author: mattsoulanille

WORKSPACE

@@ -238,3 +238,11 @@ pip_install(
     python_interpreter_target = interpreter,
     requirements = "@//tfjs-converter/python:requirements.txt",
 )
+
+load("//tfjs-tflite:tflite_repositories.bzl", "tflite_repositories")
+
+tflite_repositories()
+
+load("//tfjs-tfdf:tfdf_repositories.bzl", "tfdf_repositories")
+
+tfdf_repositories()

tfjs-tfdf/scripts/BUILD.bazel

@@ -0,0 +1,42 @@
+# Copyright 2022 Google LLC.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# =============================================================================
+
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+
+def tfdf_repositories(version = "1.1.0"):
+    versions = {
+        "1.1.0": "36b6974996d899589ba99ee95fb56699bf34c582f71e2d98475d7db4bce43b5b",
+    }
+
+    if not version in versions:
+        versions_string = ", ".join(versions.keys())
+        fail("Unsupported tfdf wasm files version %s. Supported versions are %s." %
+             (version, versions_string))
+
+    http_archive(
+        name = "tfdf_wasm_files",
+        sha256 = versions[version],
+        url = "https://github.com/google/yggdrasil-decision-forests/releases/download/%s/javascript_wasm.zip" % version,
+        build_file_content = """
+filegroup(
+    name = "wasm_files",
+    visibility = ["//visibility:public"],
+    srcs = [
+        "inference.js",
+        "inference.wasm",
+    ],
+)
+""",
+    )

tfjs-tfdf/scripts/download-tfdf-web-api.sh

@@ -13,6 +13,7 @@
 # limitations under the License.
 # =============================================================================
 
+load("//tools:copy_to_dist.bzl", "copy_to_dist")
 load("//tools:defaults.bzl", "esbuild")
 load("//tools:get_extension.bzl", "get_extension")
 
@@ -22,18 +23,14 @@ package(default_visibility = ["//visibility:public"])
 # them available for other targets.
 #
 # The downloaded files will be in `tfjs/dist/bin/tfjs-tfdf/wasm`.
-genrule(
+
+copy_to_dist(
     name = "wasm_files",
-    outs = [
-        "inference.js",
-        "inference.wasm",
-    ],
-    # $(@D) stores the output directory.
-    cmd = "$(location //tfjs-tfdf/scripts:download_tfdf_web_api) \"$(@D)\"",
-    exec_tools = [
-        "//tfjs-tfdf/scripts:download_tfdf_web_api",
+    srcs = [
+        "@tfdf_wasm_files//:wasm_files",
     ],
-    tags = ["no-remote-exec"],
+    dest_dir = ".",
+    global_root = "../tfdf_wasm_files",  # See tfdf_repositories.bzl
 )
 
 get_extension(

tfjs-tfdf/tfdf_repositories.bzl

@@ -38,7 +38,7 @@ tfjs_bundle(
         "//tfjs-tflite/src:tfjs-tflite_lib",
         "//tfjs-tflite/src:tfjs-tflite_src_lib",
         "//tfjs-tflite/src:tflite_web_api_client_js",
-        "//tfjs-tflite/wasm:wasm_files",
+        "//tfjs-tflite/wasm",
     ],
 )
 
@@ -66,15 +66,6 @@ copy_to_dist(
     ],
 )
 
-# Copy wasm related files to dist/.
-copy_to_dist(
-    name = "copy_wasm_files",
-    srcs = [
-        "//tfjs-tflite/wasm:wasm_files",
-    ],
-    root = "wasm",
-)
-
 # Package for npm.
 pkg_npm(
     name = "tfjs-tflite_pkg",
@@ -87,7 +78,7 @@ pkg_npm(
     deps = [
         ":copy_bundles",
         ":copy_src_to_dist",
-        ":copy_wasm_files",
+        "//tfjs-tflite/wasm",
     ],
 )
 

tfjs-tfdf/wasm/BUILD.bazel

@@ -84,7 +84,7 @@ esbuild(
         ":tflite_web_api_client_js",
         "//tfjs-backend-cpu/src:tfjs-backend-cpu_lib",
         "//tfjs-core/src:tfjs-core_lib",
-        "//tfjs-tflite/wasm:wasm_files",
+        "//tfjs-tflite/wasm",
     ],
 )
 
@@ -121,7 +121,7 @@ tfjs_web_test(
         "//tfjs-backend-cpu:tf-backend-cpu.min.js.map",
         "//tfjs-tflite:tf-tflite.min.js",
         "//tfjs-tflite:tf-tflite.min.js.map",
-        "//tfjs-tflite/wasm:wasm_files",
+        "//tfjs-tflite/wasm",
         "//tfjs-tflite/test_files:add4.tflite",
     ],
     deps = [

tfjs-tflite/BUILD.bazel

@@ -0,0 +1,57 @@
+# Copyright 2022 Google LLC.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# =============================================================================
+
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+
+def tflite_repositories(version = "0.0.9"):
+    versions = {
+        "0.0.3": "918dc8c5008cc57907315f78572b233abafefaf668c34e20596cedf96decf381",
+        "0.0.4": "0d6f487cf7a5afd576417381130a0d9234f1d223012d75fe58eafe98177737b2",
+        "0.0.5": "0a5fbba206016265d9422b0c9d0514591b01306e392c4f9371cf1d4352d1161d",
+        "0.0.6": "a5f197e8c8c03bbf93659c9f2d48ddb8226a6a67795677dbdb82e2a9fde0b47c",
+        "0.0.7": "ffedda0e96485adcb0fde272320e2cc121202fdbaa403dc39eaea8c1e6fac84e",
+        "0.0.8": "cb3c4ee99aacaba325dedca837c5a83828aeeb2adbcae43179a24a3e819cbcc7",
+        "0.0.9": "25819b6841dc460e43f4e43746eae3b89d6a372615cfff726495d3910fce9178",
+    }
+
+    if not version in versions:
+        versions_string = ", ".join(versions.keys())
+        fail("Unsupported tflite web api version %s. Supported versions are %s." %
+             (version, versions_string))
+
+    http_archive(
+        name = "tflite_wasm_files",
+        sha256 = versions[version],
+        url = "https://storage.googleapis.com/tfweb/%s/tflite_web_api.zip" % version,
+        build_file_content = """
+filegroup(
+    name = "wasm_files",
+    visibility = ["//visibility:public"],
+    srcs = [
+        "tflite_web_api_cc.js",
+        "tflite_web_api_cc.wasm",
+        "tflite_web_api_cc_simd.js",
+        "tflite_web_api_cc_simd_threaded.js",
+        "tflite_web_api_cc_simd_threaded.wasm",
+        "tflite_web_api_cc_simd_threaded.worker.js",
+        "tflite_web_api_cc_simd.wasm",
+        "tflite_web_api_cc_threaded.js",
+        "tflite_web_api_cc_threaded.wasm",
+        "tflite_web_api_cc_threaded.worker.js",
+        "tflite_web_api_client.js",
+    ],
+)
+""",
+    )

tfjs-tflite/scripts/BUILD.bazel

@@ -1,4 +1,4 @@
-# Copyright 2021 Google LLC. All Rights Reserved.
+# Copyright 2022 Google LLC.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -13,31 +13,16 @@
 # limitations under the License.
 # =============================================================================
 
+load("//tools:copy_to_dist.bzl", "copy_to_dist")
+
 package(default_visibility = ["//visibility:public"])
 
-# Download the TFLite web API related WASM files from google storage, and make
-# them available for other targets.
-#
-# The downloaded files will be in `tfjs/dist/bin/tfjs-tflite/wasm`.
-genrule(
-    name = "wasm_files",
-    outs = [
-        "tflite_web_api_cc.js",
-        "tflite_web_api_cc.wasm",
-        "tflite_web_api_cc_simd.js",
-        "tflite_web_api_cc_simd.wasm",
-        "tflite_web_api_cc_simd_threaded.js",
-        "tflite_web_api_cc_simd_threaded.wasm",
-        "tflite_web_api_cc_simd_threaded.worker.js",
-        "tflite_web_api_cc_threaded.js",
-        "tflite_web_api_cc_threaded.wasm",
-        "tflite_web_api_cc_threaded.worker.js",
-        "tflite_web_api_client.js",
-    ],
-    # $(@D) stores the output directory.
-    cmd = "$(location //tfjs-tflite/scripts:download_tflite_web_api) \"$(@D)\"",
-    exec_tools = [
-        "//tfjs-tflite/scripts:download_tflite_web_api",
+# Copy wasm related files to dist/.
+copy_to_dist(
+    name = "wasm",
+    srcs = [
+        "@tflite_wasm_files//:wasm_files",
     ],
-    tags = ["no-remote-exec"],
+    dest_dir = ".",
+    global_root = "../tflite_wasm_files",  # See tflite_repositories.bzl
 )