Make ts_library tsconfig.json extend root tsconfig (#6451)

* Make ts_library tsconfig.json extend root tsconfig

* Remove tsetse settings from main tsconfig

* Remove baseUrl and paths from ts_library tsconfig

* Revert "Remove baseUrl and paths from ts_library tsconfig"

Reverted since this PR should not change the tsconfig behavior (although I don't really think this change does affect behavior).

This reverts commit 2a72331.

* Lint bazel

Author: mattsoulanille

BUILD.bazel

@@ -13,10 +13,13 @@
 # limitations under the License.
 # =============================================================================
 
+load("@npm//@bazel/concatjs:index.bzl", "ts_config")
 load("//tools:tfjs_web_test.bzl", "grep_flag")
 load(":python_packages.bzl", "PYTHON_PACKAGES")
 load(":python_toolchain.bzl", "configure_python_toolchains")
 
+package(default_visibility = ["//visibility:public"])
+
 exports_files([
     "babel.config.json",
     "tsconfig.json",
@@ -25,6 +28,12 @@ exports_files([
     "tsconfig_ts_library.json",
 ])
 
+ts_config(
+    name = "tsconfig_ts_library",
+    src = "tsconfig_ts_library.json",
+    deps = [":tsconfig.json"],
+)
+
 configure_python_toolchains(
     platforms = PYTHON_PACKAGES,
 )

tools/defaults.bzl

@@ -23,7 +23,7 @@ def ts_library(**kwargs):
     # have "incremental = true" because ts_library does not support incremental
     # builds at the level of the typescript compiler (it supports incrementally
     # rebuilding at the level of Bazel build targets).
-    tsconfig = kwargs.pop("tsconfig", "@//:tsconfig_ts_library.json")
+    tsconfig = kwargs.pop("tsconfig", "@//:tsconfig_ts_library")
 
     # Use es2017 for esModule (prodmode) outputs by default. This is transpiled
     # down to es5 in tfjs_bundle.bzl. Use es5 for commonjs (devmode) outputs by

tsconfig.json

@@ -23,17 +23,7 @@
     "pretty": true,
     "noFallthroughCasesInSwitch": true,
     "allowUnreachableCode": false,
-    "incremental": true,
-    "plugins": [
-      {
-        "name": "@bazel/tsetse",
-        "disabledRules": [
-          "must-use-promises",
-          "must-type-assert-json-parse",
-          "ban-promise-as-condition"
-        ]
-      }
-    ]
+    "incremental": true
   },
   "include": [
     "**/src/"

tsconfig_ts_library.json

@@ -1,27 +1,7 @@
 {
+  "extends": "./tsconfig.json",
   "compilerOptions": {
-    "module": "ES2015",
-    "moduleResolution": "node",
-    "noImplicitAny": true,
-    "sourceMap": true,
-    "inlineSources": true,
-    "removeComments": false,
-    "preserveConstEnums": true,
-    "allowSyntheticDefaultImports": true,
-    "declaration": true,
-    "target": "es2017",
-    "lib": [
-      "es2017",
-      "dom"
-    ],
-    "noUnusedLocals": true,
-    "noImplicitReturns": true,
-    "noImplicitThis": true,
-    "alwaysStrict": true,
-    "noUnusedParameters": false,
-    "pretty": true,
-    "noFallthroughCasesInSwitch": true,
-    "allowUnreachableCode": false,
+    "incremental": false,
     "baseUrl": ".",
     "paths": {
       "@tensorflow/*": [