Skip to content

Commit 2824075

Browse files
authored
rust: run libc build script (#4336)
Summary: When setting up the transitive dep on `libc` in #4316, I had originally passed `--cfg=libc_align`, because that fixed the build for me and on CI, and I couldn’t figure out the right cross-platform fix. But @faern [helpfully points out that we just need to run the build script][1], which detects the OS and Rust compiler version to determine the appropriate flags. Bazel `rules_rust` can handle this, if we just ask. (I should have followed my own `DEVELOPMENT.md` suggestions!) [1]: rust-lang/socket2#130 (comment) Test Plan: It still builds—`bazel build @raze__libc__0_2_80//:libc`—and the demo server still works and accepts requests following #4318’s test plan. wchargin-branch: rust-libc-gen-buildrs
1 parent 35171dc commit 2824075

File tree

2 files changed

+32
-6
lines changed

2 files changed

+32
-6
lines changed

tensorboard/data/server/Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ targets = [
6060
gen_buildrs = true
6161

6262
[package.metadata.raze.crates.libc.'0.2.80']
63-
additional_flags = [
64-
"--cfg=libc_align",
65-
]
63+
gen_buildrs = true
6664

6765
[package.metadata.raze.crates.indexmap.'1.6.0']
6866
additional_flags = [

third_party/rust/remote/BUILD.libc-0.2.80.bazel

Lines changed: 31 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)