Skip to content
This repository was archived by the owner on Apr 23, 2021. It is now read-only.

Commit 4aa0a85

Browse files
joker-ephtensorflower-gardener
authored andcommitted
Use "final" instead of marking method virtual in override (NFC)
This is the only example for overriding this interface in the repo, let's try to make it right as it may be taken as a reference when implemented in other dialects PiperOrigin-RevId: 267811123
1 parent bbe1ccf commit 4aa0a85

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/lib/TestDialect/TestDialect.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct TestOpFolderDialectInterface : public OpFolderDialectInterface {
3434
/// Registered hook to check if the given region, which is attached to an
3535
/// operation that is *not* isolated from above, should be used when
3636
/// materializing constants.
37-
virtual bool shouldMaterializeInto(Region *region) const {
37+
bool shouldMaterializeInto(Region *region) const final {
3838
// If this is a one region operation, then insert into it.
3939
return isa<OneRegionOp>(region->getParentOp());
4040
}

0 commit comments

Comments
 (0)