Deny lints pre-ArgAbi codegen used to trigger (pgcentralfoundation#1744)

Lifts instances of crate-wide lint control into Cargo.toml and denies
some of them for pgrx-tests so that pgrx's macro expansions no longer
emit needless `allow`s in quite as many places. This also trims away a
few now-needless allowances.

Author: workingjubilee

cargo-pgrx/Cargo.toml

@@ -70,3 +70,6 @@ rustls = [
     "ureq/tls",
     "ureq/native-certs" # induces rustls to use the OS-level root of trust
 ]
+
+[lints.clippy]
+or-fun-call = "allow" # kinda sus lint imo

cargo-pgrx/src/main.rs

@@ -7,9 +7,6 @@
 //LICENSE All rights reserved.
 //LICENSE
 //LICENSE Use of this source code is governed by the MIT license that can be found in the LICENSE file.
-#![deny(clippy::perf)] // our compile times are awful
-#![allow(clippy::or_fun_call)] // often false positives
-
 mod command;
 mod manifest;
 mod metadata;

pgrx-macros/src/rewriter.rs

@@ -36,7 +36,7 @@ pub fn item_fn_without_rewrite(mut func: ItemFn) -> syn::Result<proc_macro2::Tok
     let input_func_name = func.sig.ident.to_string();
     let sig = func.sig.clone();
     let vis = func.vis.clone();
-    let mut attrs = mem::take(&mut func.attrs);
+    let attrs = mem::take(&mut func.attrs);
     let generics = func.sig.generics.clone();
 
     if attrs.iter().any(|attr| attr.path().is_ident("no_mangle"))
@@ -58,14 +58,6 @@ pub fn item_fn_without_rewrite(mut func: ItemFn) -> syn::Result<proc_macro2::Tok
 
     func.sig.ident = format_ident!("{}_inner", func.sig.ident);
 
-    // the wrapper_inner function declaration may contain lifetimes that are not used, since our input type is `FunctionCallInfo` mainly and return type is `Datum`
-    let unused_lifetimes = match generics.lifetimes().next() {
-        Some(_) => quote! {
-            #[allow(unused_lifetimes, clippy::extra_unused_lifetimes)]
-        },
-        None => quote! {},
-    };
-
     let arg_list = build_arg_list(&sig, false)?;
     let func_name = func.sig.ident.clone();
 
@@ -103,7 +95,6 @@ pub fn item_fn_without_rewrite(mut func: ItemFn) -> syn::Result<proc_macro2::Tok
         #(#attrs)*
         #vis #sig {
             #[allow(non_snake_case)]
-            #unused_lifetimes
             #func
 
             #[allow(unused_unsafe)]

pgrx-pg-sys/Cargo.toml

@@ -63,3 +63,13 @@ bindgen = { version = "0.69", default-features = false, features = ["runtime"] }
 clang-sys = { version = "1", features = ["clang_6_0", "runtime"] }
 quote = "1.0.33"
 shlex = "1.3" # shell lexing, also used by many of our deps
+
+[lints]
+# we allow improper_ctypes just to eliminate these warnings:
+#      = note: `#[warn(improper_ctypes)]` on by default
+#      = note: 128-bit integers don't currently have a known stable ABI
+rust.non_camel_case_types = "allow"
+rust.non_snake_case = "allow"
+rust.dead_code = "allow"
+rust.non_upper_case_globals = "allow"
+rust.improper_ctypes = "allow"

pgrx-pg-sys/src/lib.rs

@@ -7,17 +7,6 @@
 //LICENSE All rights reserved.
 //LICENSE
 //LICENSE Use of this source code is governed by the MIT license that can be found in the LICENSE file.
-//
-// we allow improper_ctypes just to eliminate these warnings:
-//      = note: `#[warn(improper_ctypes)]` on by default
-//      = note: 128-bit integers don't currently have a known stable ABI
-#![allow(non_camel_case_types)]
-#![allow(non_snake_case)]
-#![allow(dead_code)]
-#![allow(non_upper_case_globals)]
-#![allow(improper_ctypes)]
-#![allow(clippy::unneeded_field_pattern)]
-
 #[cfg(
     // no features at all will cause problems
     not(any(feature = "pg12", feature = "pg13", feature = "pg14", feature = "pg15", feature = "pg16")),

pgrx-sql-entity-graph/Cargo.toml

@@ -42,3 +42,4 @@ syntect = { version = "5.1.0", default-features = false, features = ["default-fa
 
 [lints.clippy]
 assigning-clones = "allow" # wrong diagnosis and wrong suggestions
+too-many-arguments = "allow" # I argue with myself all the time

pgrx-sql-entity-graph/src/finfo.rs

@@ -26,21 +26,11 @@ pub fn finfo_v1_extern_c(
 ) -> syn::Result<ItemFn> {
     let original_name = &original.sig.ident;
     let wrapper_symbol = format_ident!("{}_wrapper", original_name);
-    let lifetimes = &original.sig.generics;
-    // the wrapper function declaration may contain lifetimes that are not used, since
-    // our input type is FunctionCallInfo and our return type is Datum
-    let unused_lifetimes = match lifetimes.lifetimes().next() {
-        Some(_) => quote! {
-            #[allow(unused_lifetimes, clippy::extra_unused_lifetimes)]
-        },
-        None => quote! {},
-    };
 
     let tokens = quote_spanned! { original.sig.span() =>
         #[no_mangle]
         #[doc(hidden)]
-        #unused_lifetimes
-        pub unsafe extern "C" fn #wrapper_symbol #lifetimes(#fcinfo: ::pgrx::pg_sys::FunctionCallInfo) -> ::pgrx::pg_sys::Datum {
+        pub unsafe extern "C" fn #wrapper_symbol(#fcinfo: ::pgrx::pg_sys::FunctionCallInfo) -> ::pgrx::pg_sys::Datum {
             #contents
         }
     };

pgrx-sql-entity-graph/src/lib.rs

@@ -15,8 +15,6 @@ Rust to SQL mapping support.
 to the `pgrx` framework and very subject to change between versions. While you may use this, please do it with caution.
 
 */
-#![allow(clippy::too_many_arguments)]
-#![allow(clippy::redundant_pattern_matching)]
 pub use aggregate::entity::{AggregateTypeEntity, PgAggregateEntity};
 pub use aggregate::{
     AggregateType, AggregateTypeList, FinalizeModify, ParallelOption, PgAggregate,

pgrx-sql-entity-graph/src/pgrx_attribute.rs

@@ -65,7 +65,7 @@ impl Parse for PgrxArg {
     #[track_caller]
     fn parse(input: ParseStream<'_>) -> syn::Result<Self> {
         let path = input.parse::<syn::Path>()?;
-        if let Ok(_) = input.parse::<Token![=]>() {
+        if input.parse::<Token![=]>().is_ok() {
             Ok(Self::NameValue(NameValueArg { path, value: input.parse()? }))
         } else {
             Err(input.error("unsupported argument to #[pgrx] in this context"))

pgrx-tests/Cargo.toml

@@ -76,3 +76,7 @@ version = "=0.12.0-alpha.1"
 [dev-dependencies]
 eyre.workspace = true # testing functions that return `eyre::Result`
 trybuild = "1"
+
+[lints]
+rust.unused-lifetimes = "deny"
+clippy.used-underscore-binding = "deny"