Skip to content

[Feature Request] Add typing for signal for PyCharm #1220

@trajano

Description

@trajano

Is your feature request related to a problem? Please describe.

PyCharm complains on a no-arg signal

await handler.signal(PlaceholderWorkflow.terminate)

Describe the solution you'd like

Can this be added to WorkflowHandle in client.py

    @overload
    async def signal(
        self,
        signal: Callable[SelfType, None],
        *,
        rpc_metadata: Mapping[str, Union[str, bytes]] = {},
        rpc_timeout: Optional[timedelta] = None,
    ) -> None: ...

Additional context

PyRight works, just PyCharm isn't working as expected but having that line works in both PyRight and PyCharm

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions