TODOs

Author: dandavison

temporalio/converter.py

@@ -1054,9 +1054,7 @@ def from_failure(
             #     temporal.api.enums.v1.NexusHandlerErrorRetryBehavior retry_behavior = 2;
             # }
             # TODO(dan): core never sends this currently?
-            raise NotImplementedError(
-                "TODO: Nexus handler failure info not implemented"
-            )
+            raise NotImplementedError("Nexus handler failure info not implemented")
         elif failure.HasField("nexus_operation_execution_failure_info"):
             # message NexusOperationFailureInfo {
             #     // The NexusOperationScheduled event ID.

temporalio/nexus/handler.py

@@ -307,14 +307,14 @@ def __init__(
     ):
         self.service = service
 
-        # TODO: get rid of first parameter?
+        # TODO(dan): get rid of first parameter?
         @wraps(start_method)
         async def start(
             self, input: I, options: nexusrpc.handler.StartOperationOptions
         ) -> StartWorkflowOperationResult[O]:
             return await start_method(service, input, options)
 
-        # TODO: get rid of first parameter?
+        # TODO(dan): get rid of first parameter?
         async def fetch_result(
             self, token: str, options: nexusrpc.handler.FetchOperationResultOptions
         ) -> O:

temporalio/worker/_nexus.py

@@ -126,7 +126,7 @@ async def run(self) -> None:
             assert op, f"Failed to classify Nexus task: {task_python}"
             print(f"🟢 _NexusWorker received '{op}' operation")
 
-            # TODO: Correct way to examine and classify task proto
+            # TODO(dan): Correct way to examine and classify task proto
             if task.HasField("task"):
                 if task.task.request.HasField("start_operation"):
                     await self._handle_start_operation(

tests/worker/test_nexus.py

@@ -642,7 +642,7 @@ class ServiceClassNameOutput:
     name: str
 
 
-# TODO: test interface op types not matching
+# TODO(dan): test interface op types not matching
 
 
 @nexusrpc.interface.service