Don't interrupt thread from Rust

Author: dandavison

temporalio/worker/_workflow.py

@@ -667,9 +667,7 @@ def attempt_deadlock_interruption(self) -> None:
                 return
             deadlocked_thread_id = self.instance.get_thread_id()
             if deadlocked_thread_id:
-                temporalio.bridge.runtime.Runtime._raise_in_thread(
-                    deadlocked_thread_id, _InterruptDeadlockError
-                )
+                pass
 
 
 class _InterruptDeadlockError(BaseException):

tests/worker/test_workflow.py

@@ -6994,35 +6994,6 @@ async def run(self) -> None:
             deadlock_interruptible_completed += 1
 
 
-async def test_workflow_deadlock_interruptible(client: Client):
-    # TODO(cretz): Improve this test and other deadlock/eviction tests by
-    # checking slot counts with Core. There are a couple of bugs where used slot
-    # counts are off by one and slots are released before eviction (see
-    # https://github.com/temporalio/sdk-core/issues/894).
-
-    # This worker used to not be able to shutdown because we hung evictions on
-    # deadlock
-    async with new_worker(client, DeadlockInterruptibleWorkflow) as worker:
-        # Start the workflow
-        assert deadlock_interruptible_completed == 0
-        handle = await client.start_workflow(
-            DeadlockInterruptibleWorkflow.run,
-            id=f"workflow-{uuid.uuid4()}",
-            task_queue=worker.task_queue,
-        )
-        # Wait for task fail
-        await assert_task_fail_eventually(handle, message_contains="deadlock")
-
-        # Confirm workflow was interrupted
-        async def check_completed():
-            assert deadlock_interruptible_completed >= 1
-
-        await assert_eventually(check_completed)
-        completed_sec = time.monotonic()
-    # Confirm worker shutdown didn't hang
-    assert time.monotonic() - completed_sec < 20
-
-
 deadlock_uninterruptible_event = threading.Event()
 deadlock_uninterruptible_completed = 0