Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of the plugin #1

Open
Morl99 opened this issue Sep 20, 2022 · 12 comments
Open

Future of the plugin #1

Morl99 opened this issue Sep 20, 2022 · 12 comments
Labels
question Further information is requested

Comments

@Morl99
Copy link

Morl99 commented Sep 20, 2022

Hello! I am trying to chime in interested people into a discussion about the Future of this plugin. If you like, please take a look at this PR.

@gbbirkisson
Copy link

Hi. The initial author of the plugin here. I think it is time to archive the original repository. I will gladly put a link in the README to the successor of the original plugin. The original repo has 85 forks currently, so I guess it could be up for debate which fork should be considered the successor. Any thoughts on this?

@Morl99
Copy link
Author

Morl99 commented Dec 9, 2022

That is what I was trying to figure out as well. Thanks for chiming in. It looks like we have not yet found anyone that want's to take over. let's wait and see.

@Gruummy
Copy link
Collaborator

Gruummy commented Aug 6, 2023

Hi @Morl99 and @gbbirkisson
i am one of the colleagues which use your plugin in our projekt.
We currently use kong 2.8.3 .. so we had not recognized that here such an issue had beed created.

But now i see it.

The next months we will work on the topic about migration to kong 3.x and when i think about this ... then we also need to port the plugin.

Our project will exist currently longer for ... i think ... a couple of years.
We also have currently no plans to leave kong ... and we use by intention kong OSS ... (Community edition)

Also by intention we made the fork open visible in github. There had been discussions to host it only inhouse ... but this will not happen.

We do not really want to maintain officially a internet repo in our project .. but we will make everything available here.

I think this is the way how opensource should work

@Gruummy Gruummy added the question Further information is requested label Aug 10, 2023
@gbbirkisson
Copy link

It sounds good to me @ZeeFiix. I will update the README in the original repo pointing to the new repo (https://github.com/telekom-digioss/kong-plugin-jwt-keycloak).

I will also point everyone that has opened issues in the old repo to repoen them in the new repo. I will also do that for PRs.

Once that is done, I will give it a couple of weeks until I archive the repo, just so no issues, PRs are lost.

Sounds good @Morl99 @ZeeFiix ?

@Gruummy
Copy link
Collaborator

Gruummy commented Aug 11, 2023

@gbbirkisson For me yes ...

@Morl99
Copy link
Author

Morl99 commented Aug 11, 2023

Nice, thank you!

@gbbirkisson
Copy link

Allright, I have pointed all issues/PRs to move over to this repo. I have also updated the README. I will give it some time before I archive the old repo.

@walter-bd
Copy link

Another good fork is this one https://github.com/hanfi/kong-plugin-jwt-keycloak, he adapted the plugin so it works on kong 3.x.x

@Morl99
Copy link
Author

Morl99 commented Aug 14, 2023

I would vote to stay with the telekom fork and merge the changes from hanfi back into that one. Maybe @hanfi is willing to contribute to the new fork as well.

@telekom-digioss
Copy link
Owner

telekom-digioss commented Aug 15, 2023

@Morl99 and @walter-bd
I already have done these .. and other changes meanwhile ... and merged it to master

@gbbirkisson
Copy link

Allright, I have pointed all issues/PRs to move over to this repo. I have also updated the README. I will give it some time before I archive the old repo.

I have now archived the old! Thanks for keeping the project alive, and good luck with everything!

madestreel added a commit to Escaux/kong-plugin-jwt-keycloak that referenced this issue Nov 16, 2023
…-in-body

Feature: Allow to retrieve the JWT from the body
@ebarped
Copy link

ebarped commented May 16, 2024

Are you still maintaining this? I see a breaking change in #9 from january, already 4 months old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants