Skip to content

Commit 87aeec8

Browse files
RajeshwriKRajeshwari Kiwad
andauthored
checkbox alignment correction (#8)
Contains changes related to the list checkbox and edit button alignment and styling, for step as a local property and for sweep as a global property with automation ids --------- Co-authored-by: Rajeshwari Kiwad <[email protected]>
1 parent 9b95c79 commit 87aeec8

File tree

4 files changed

+59
-43
lines changed

4 files changed

+59
-43
lines changed

script-gen-ui/src/app/components/main-sweep/main-sweep.component.html

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@
77
<div class="parent-container">
88
<div
99
class="input-container"
10-
style="overflow: auto; max-height: 100vh; min-width: min-content; min-height: 40vh;"
10+
style="
11+
overflow: auto;
12+
max-height: 100vh;
13+
min-width: min-content;
14+
min-height: 40vh;
15+
"
1116
>
1217
<div class="timing-autorangebox">
1318
<div [attr.aria-label]="'timingTab'">
@@ -228,12 +233,20 @@ <h3>Sweep</h3>
228233
name="isListSweep"
229234
(change)="updateSweepGlobalParameters()"
230235
/>
231-
<label for="list" style="margin-top: 4.5vh; margin-left: 5px"
236+
<label
237+
for="list"
238+
style="margin-top: auto; margin-left: 3px; margin-bottom: 1vh"
232239
>List</label
233240
>
234241
</div>
235-
<div style="margin-top: 2.9vh">
236-
<button class="timing" (click)="enableList()">Edit</button>
242+
<div style="margin-top: auto; margin-bottom: 0.5vh">
243+
<button
244+
[attr.aria-label]="'EditSweepList'"
245+
class="timing"
246+
(click)="enableList()"
247+
>
248+
Edit
249+
</button>
237250
<app-list
238251
*ngIf="showList"
239252
[listsWithNames]="sweepListsWithNames"

script-gen-ui/src/app/components/main-sweep/main-sweep.component.scss

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,10 @@
275275
}
276276

277277
.checkbox input {
278-
margin-top: 4.2vh;
278+
margin-top: auto;
279279
box-sizing: border-box;
280280
appearance: none;
281-
padding: 1.3vh;
281+
padding: 10px;
282282
border-radius: 3px;
283283
}
284284

@@ -287,17 +287,17 @@
287287
}
288288

289289
.checkbox input[type="checkbox"]:checked::after {
290-
content: "";
291-
left: 5px;
292-
top: 1px;
293-
width: 5px;
294-
height: 10px;
295-
border: solid var(--vscode-activityBar-activeBorder);
296-
border-width: 0 2px 2px 0;
297-
transform: rotate(45deg);
298-
display: block;
299-
margin: -6.5px -3px -3px -2px;
300-
margin-left: -2.5px;
290+
content: "";
291+
left: 5px;
292+
top: 1px;
293+
width: 5px;
294+
height: 10px;
295+
border: solid var(--vscode-activityBar-activeBorder);
296+
border-width: 0 2px 2px 0;
297+
transform: rotate(45deg);
298+
display: block;
299+
margin: -6.5px -3px -3px -2px;
300+
margin-left: -2.5px;
301301
}
302302

303303
.h3 {

script-gen-ui/src/app/components/main-sweep/step/step.component.html

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,22 +161,27 @@ <h3>
161161
></app-input-toggle>
162162
</div>
163163
<div class="checkbox">
164-
<div style="display: inline-flex">
164+
<div
165+
style="display: inline-flex; margin-top: auto; margin-bottom: -0.3vh"
166+
>
165167
<input
166168
type="checkbox"
167-
id="listStep"
168169
[attr.aria-label]="'listStep'"
169170
[(ngModel)]="listStep"
170171
name="listStep"
171172
(change)="submitStepGlobalParamsData()"
172-
style="margin-top: 4.2vh"
173173
[disabled]="!selectedDeviceOption?.isValid"
174174
/>
175-
<label for="list" style="margin-top: 4vh; margin-left: 5px">List</label>
175+
<label
176+
for="list"
177+
style="margin-left: 3px; margin-top: auto; margin-bottom: auto"
178+
>List</label
179+
>
176180
</div>
177-
<div style="margin-top: 2.7vh; margin-left: 3vw">
181+
<div style="margin-top: auto; margin-bottom: 0.5vh; margin-left: 3vh">
178182
<button
179183
class="timing"
184+
[attr.aria-label]="'EditStepList'"
180185
(click)="showStepListPopup()"
181186
[disabled]="!selectedDeviceOption?.isValid"
182187
>

script-gen-ui/src/app/components/main-sweep/step/step.component.scss

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -166,25 +166,26 @@ h4 {
166166
}
167167

168168
.checkbox input[type="checkbox"]:checked::after {
169-
content: "";
170-
left: 5px;
171-
top: 1px;
172-
width: 5px;
173-
height: 10px;
174-
border: solid var(--vscode-activityBar-activeBorder);
175-
border-width: 0 2px 2px 0;
176-
transform: rotate(45deg);
177-
display: block;
178-
margin: -6.5px -3px -3px -1.6px;
179-
margin-left: -3px;
180-
margin-top: -7px;
169+
content: "";
170+
left: 5px;
171+
top: 1px;
172+
width: 5px;
173+
height: 10px;
174+
border: solid var(--vscode-activityBar-activeBorder);
175+
border-width: 0 2px 2px 0;
176+
transform: rotate(45deg);
177+
display: block;
178+
margin: -6.5px -3px -3px -1.6px;
179+
margin-left: -3px;
180+
margin-top: -7px;
181181
}
182182

183183
.checkbox input {
184-
margin-top: 3.5vh;
184+
margin-top: auto;
185185
box-sizing: border-box;
186-
padding: 1.3vh;
187-
border-radius: 4px;
186+
appearance: none;
187+
padding: 10px;
188+
border-radius: 3px;
188189
}
189190

190191
.checkbox input[type="checkbox"] {
@@ -204,16 +205,13 @@ h4 {
204205
}
205206

206207
.timing {
207-
border-radius: 10px;
208-
background-color: var(--vscode-editor-background);
208+
border-radius: 13px;
209+
background-color: transparent;
209210
color: var(--vscode-activityBarBadge-foreground);
210-
padding: 5px;
211211
border-color: var(--vscode-activityBar-activeBorder);
212212
border-style: solid;
213213
border-width: thin;
214-
padding-left: 10px;
215-
padding-right: 10px;
216-
// margin-left: 8vh;
214+
padding: 5px 15px;
217215
}
218216

219217
button.timing:disabled {

0 commit comments

Comments
 (0)