Skip to content

Commit 077c21b

Browse files
kaur-mananjeetGT, ShreyaRajeshwari Kiwad
authored
Fix: Restrict timing tab drag to WebView window (#47)
* TSP-947 Script generation infrastructure first cut * TSP-947 Fix multiple channel issue in script * TSP-948 Fix linting issues * TSP-Script-Gen-UI- Linting done (both angular and rust) * TSP-Script-Gen-UI step and sweep points update fixed to show on plot * TSP-Script-Gen All linitng done with standalones * TSP-960-Scrolling input containers to view done * TSP-Scrip-Gen-UI- Scroll into view feature done * Script-Gen-UI- UI changes done (through reviews from UX team) * Revert "Merge branch 'main' into task/TSP-960-style-layout" This reverts commit 12b90fcd4c35917273d40a01e1c5f21dfc5ac79e, reversing changes made to beb512d73be7731c565fec696796c0cd47e5878a. * Reapply "Merge branch 'main' into task/TSP-960-style-layout" This reverts commit 712497e134fc83278e4ec837ff50212ac1f77484. * TSP-960-Scroll-Into-View done with UI changes * TSP-944-resizing and layout of the input containers done * Script-Gen-UI- Fixed the error and bias plot background color * Script-Gen-UI- Sweep color fix * Script-Gen-UI- fixed arrows and step add and remove button * TSP-944- Input panes reflow when shrunk done * Added styles to timing popup * Removed files as per review comment * tsp-1123-Fix start and stop CSS in Step and Sweep Section * Fix start and stop border in step and sweep * tsp-1123-Fix leaking CSS in start and stop * Task/tsp-1201-Correct the spelling of the "Aperture" textbox in the Timing tab * task/tsp-1199-fix-automation name & IDs are missing for the combo box and textboxes in the Timing Tab * fix automation IDs for measure delay and rate * remove duplicate automationID from input-numeric * TSP-1202-add automation Names and automationIDs for Bias * Fix automation names for NPLC and Aperture in Timing * fix issue with automation names in timing and bias (script-gen) * fix: bias plot range for source range AUTO * fix: tsp-1230 and tsp-1231 -The automation name & IDs are missing for the combo box and textboxes in the Step -The automation name & IDs are missing for the combo box and textboxes in the Sweep * fix: Script Gen- Sweep Graph Preview Cuts Off End of Graph * refactor: move repeated code into function generatePlotData() * fix: restrict timing tab drag to webview panel --------- Co-authored-by: GT, Shreya <[email protected]> Co-authored-by: Rajeshwari Kiwad <[email protected]>
1 parent adbe5c0 commit 077c21b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

script-gen-ui/src/app/components/main-sweep/timing/timing.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="popup">
2-
<div class="popup-content" cdkDrag>
2+
<div class="popup-content" cdkDrag [cdkDragBoundary]="boundaryElement">
33
<!-- <span class="close" (click)="close_Timing()">&times;</span> -->
44
<div>
55
<div class="popup-header">

script-gen-ui/src/app/components/main-sweep/timing/timing.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ export class TimingComponent implements OnDestroy, OnChanges {
5858

5959
timingOption: 'smuTiming' | 'psuTiming' = 'smuTiming';
6060

61+
boundaryElement = 'app-root';
62+
6163
@Input() sweepTimingConfig: SweepTimingConfig | undefined;
6264
@Output() ok = new EventEmitter<void>();
6365
@Output() emitTimingData = new EventEmitter<void>();

0 commit comments

Comments
 (0)