Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datamodel unitary tests for SWMM #76

Open
1 task
sjib opened this issue May 19, 2023 · 0 comments
Open
1 task

Improve datamodel unitary tests for SWMM #76

sjib opened this issue May 19, 2023 · 0 comments
Labels
Sustainability Sustainability / Maintenance TEKSI wastewater TEKSI wastewater module

Comments

@sjib
Copy link
Contributor

sjib commented May 19, 2023

Description

In https://github.com/QGEP/datamodel/blob/master/test/test_swmm.py, the tests are based on the number of object expected in the views. Once that the SWMM export will be more mature, the tests should rely on the number of objects in the main tables.

Exemple: If there are 5095 reaches in qgep_od.reach, there should be 5095 conduits in SWMM.

However, other relations might be less straightforward.

Even with the reaches the number of objects should differ eventually, as we dont need abandonded reaches in the SWMM model.
In general, we should overthink the way we handle the statuses planned and current. Elements may be only current (statuses operational.tentative and operational.will_be_suspended), current and planned (operative), planned only (other.) or none of the above (inoperative, abandoned.)

Related issue:

@sjib sjib converted this from a draft issue May 19, 2023
@sjib sjib added TEKSI wastewater TEKSI wastewater module Sustainability Sustainability / Maintenance labels May 19, 2023
@sjib sjib added this to the TEKSI wastewater 2024.0 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sustainability Sustainability / Maintenance TEKSI wastewater TEKSI wastewater module
Projects
Development

No branches or pull requests

1 participant