Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AngularTemplatesAsset should support Jade templates #82

Open
dankohn opened this issue Jul 3, 2013 · 2 comments · May be fixed by #80
Open

AngularTemplatesAsset should support Jade templates #82

dankohn opened this issue Jul 3, 2013 · 2 comments · May be fixed by #80

Comments

@dankohn
Copy link

dankohn commented Jul 3, 2013

We're using Jade for our Angular templates. How would you feel about a pull request that caused AngularTemplatesAsset to look for Jade assets as well as HTML, and that automatically compiles any Jade files it found? Does it even need an option to turn off the Jade compilation functionality?

Separately, our HTML page will then be referencing 3 fingerprinted files: the site Javascript bundle, the site CSS bundle, and the site AngularTemplates bundle. What's the possibility of combining 1 and 3 into a single bundle?
@techpines
Copy link
Owner

Totally cool with the pull request.

Here is a thought for how the api might look for combining 1 & 3, which I think is a good idea:

new BrowserifyAsset({
    prepend: new AngularTemplatesAsset({}),
    filename: __dirname + '/browser/app.js',
    url: '/app.js'
});

Also, I'd love to make the new keyword optional for asset-rack. I've seen people do it in other libraries and I'd like to do it here, and I was wondering if you know how to set something like that up.

@bryanchriswhite
Copy link

partially fixed by #107

@bryanchriswhite bryanchriswhite mentioned this issue Nov 2, 2013
Closed
@dankohn dankohn mentioned this issue Nov 4, 2013
Open
@bryanchriswhite bryanchriswhite linked a pull request Nov 14, 2013 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AngularTemplateAsset support for Jade and Browserify fixes shopbeam/asset-rack
3 participants
@bryanchriswhite @techpines @dankohn