Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is massive rewrite ready? #7

Open
lostmsu opened this issue Mar 15, 2023 · 1 comment
Open

Is massive rewrite ready? #7

lostmsu opened this issue Mar 15, 2023 · 1 comment

Comments

@lostmsu
Copy link

lostmsu commented Mar 15, 2023

Or should I use one of the older commits?

Perhaps tag a "stable" v0.0.1 on one of the older commits?

P.S. right now I imported the project into VS 2022, which got PlatformToolset upgraded to v143. As-is the solution does not compile because the example cpp tries to include main headers, but the path to them is not set.

P.P.S. The .vcxproj.user file is not supposed to be checked in.

@techiew
Copy link
Owner

techiew commented Mar 16, 2023

I've gotten reports that the newest commit has instability related to the new hooking method - it is now more advanced compared to the simple VMT pointer switch, but also less confusing to third party hooks, i.e. more standard. The problem is it doesn't handle differences in instructions at the top of the functions that are hooked (which vary on different people's PCs), the instructions apparently change quite a bit depending on your version of Windows, etc... I will have a fix for this soon.

The previous commit does not have this problem, but will with some combinations of third-party overlays cause crashes.

I'll look into adding tags, having a separate master and develop branch, etc. I'll also look into your other points. I've only just begun rewriting and cleaning up the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants