Skip to content

Commit 154cefe

Browse files
dev-domodev-domo
authored
Chore/#74 logger privacy 레벨 수정 (#77)
* chore: #74 Logger privacy 레벨 수정 * chore: #74 skip_testing 옵션 제거 * chore: #74 Add skip_testing option to Fastfile * setting: #74 UITest 타겟 제외 * chore: #74 skip_testing 제거 Removed skip_testing option from the Fastfile.
1 parent d86e01e commit 154cefe

3 files changed

Lines changed: 4 additions & 115 deletions

File tree

‎BeforeGoing.xcodeproj/project.pbxproj‎

Lines changed: 0 additions & 110 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,11 @@
2222
remoteGlobalIDString = 186E06DA2DDDF10500E32490;
2323
remoteInfo = BeforeGoing;
2424
};
25-
186E06FC2DDDF10600E32490 /* PBXContainerItemProxy */ = {
26-
isa = PBXContainerItemProxy;
27-
containerPortal = 186E06D32DDDF10500E32490 /* Project object */;
28-
proxyType = 1;
29-
remoteGlobalIDString = 186E06DA2DDDF10500E32490;
30-
remoteInfo = BeforeGoing;
31-
};
3225
/* End PBXContainerItemProxy section */
3326

3427
/* Begin PBXFileReference section */
3528
186E06DB2DDDF10500E32490 /* BeforeGoing.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = BeforeGoing.app; sourceTree = BUILT_PRODUCTS_DIR; };
3629
186E06F12DDDF10600E32490 /* BeforeGoingTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BeforeGoingTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
37-
186E06FB2DDDF10600E32490 /* BeforeGoingUITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BeforeGoingUITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
3830
D2E280C62E41AE3900A90122 /* KakaoSDKFriendResources.bundle */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.plug-in"; path = KakaoSDKFriendResources.bundle; sourceTree = "<group>"; };
3931
/* End PBXFileReference section */
4032

@@ -88,13 +80,6 @@
8880
);
8981
runOnlyForDeploymentPostprocessing = 0;
9082
};
91-
186E06F82DDDF10600E32490 /* Frameworks */ = {
92-
isa = PBXFrameworksBuildPhase;
93-
buildActionMask = 2147483647;
94-
files = (
95-
);
96-
runOnlyForDeploymentPostprocessing = 0;
97-
};
9883
/* End PBXFrameworksBuildPhase section */
9984

10085
/* Begin PBXGroup section */
@@ -115,7 +100,6 @@
115100
children = (
116101
186E06DB2DDDF10500E32490 /* BeforeGoing.app */,
117102
186E06F12DDDF10600E32490 /* BeforeGoingTests.xctest */,
118-
186E06FB2DDDF10600E32490 /* BeforeGoingUITests.xctest */,
119103
);
120104
name = Products;
121105
sourceTree = "<group>";
@@ -179,29 +163,6 @@
179163
productReference = 186E06F12DDDF10600E32490 /* BeforeGoingTests.xctest */;
180164
productType = "com.apple.product-type.bundle.unit-test";
181165
};
182-
186E06FA2DDDF10600E32490 /* BeforeGoingUITests */ = {
183-
isa = PBXNativeTarget;
184-
buildConfigurationList = 186E070C2DDDF10600E32490 /* Build configuration list for PBXNativeTarget "BeforeGoingUITests" */;
185-
buildPhases = (
186-
186E06F72DDDF10600E32490 /* Sources */,
187-
186E06F82DDDF10600E32490 /* Frameworks */,
188-
186E06F92DDDF10600E32490 /* Resources */,
189-
);
190-
buildRules = (
191-
);
192-
dependencies = (
193-
186E06FD2DDDF10600E32490 /* PBXTargetDependency */,
194-
);
195-
fileSystemSynchronizedGroups = (
196-
186E06FE2DDDF10600E32490 /* BeforeGoingUITests */,
197-
);
198-
name = BeforeGoingUITests;
199-
packageProductDependencies = (
200-
);
201-
productName = BeforeGoingUITests;
202-
productReference = 186E06FB2DDDF10600E32490 /* BeforeGoingUITests.xctest */;
203-
productType = "com.apple.product-type.bundle.ui-testing";
204-
};
205166
/* End PBXNativeTarget section */
206167

207168
/* Begin PBXProject section */
@@ -219,10 +180,6 @@
219180
CreatedOnToolsVersion = 16.2;
220181
TestTargetID = 186E06DA2DDDF10500E32490;
221182
};
222-
186E06FA2DDDF10600E32490 = {
223-
CreatedOnToolsVersion = 16.2;
224-
TestTargetID = 186E06DA2DDDF10500E32490;
225-
};
226183
};
227184
};
228185
buildConfigurationList = 186E06D62DDDF10500E32490 /* Build configuration list for PBXProject "BeforeGoing" */;
@@ -247,7 +204,6 @@
247204
targets = (
248205
186E06DA2DDDF10500E32490 /* BeforeGoing */,
249206
186E06F02DDDF10600E32490 /* BeforeGoingTests */,
250-
186E06FA2DDDF10600E32490 /* BeforeGoingUITests */,
251207
);
252208
};
253209
/* End PBXProject section */
@@ -268,13 +224,6 @@
268224
);
269225
runOnlyForDeploymentPostprocessing = 0;
270226
};
271-
186E06F92DDDF10600E32490 /* Resources */ = {
272-
isa = PBXResourcesBuildPhase;
273-
buildActionMask = 2147483647;
274-
files = (
275-
);
276-
runOnlyForDeploymentPostprocessing = 0;
277-
};
278227
/* End PBXResourcesBuildPhase section */
279228

280229
/* Begin PBXSourcesBuildPhase section */
@@ -292,13 +241,6 @@
292241
);
293242
runOnlyForDeploymentPostprocessing = 0;
294243
};
295-
186E06F72DDDF10600E32490 /* Sources */ = {
296-
isa = PBXSourcesBuildPhase;
297-
buildActionMask = 2147483647;
298-
files = (
299-
);
300-
runOnlyForDeploymentPostprocessing = 0;
301-
};
302244
/* End PBXSourcesBuildPhase section */
303245

304246
/* Begin PBXTargetDependency section */
@@ -307,11 +249,6 @@
307249
target = 186E06DA2DDDF10500E32490 /* BeforeGoing */;
308250
targetProxy = 186E06F22DDDF10600E32490 /* PBXContainerItemProxy */;
309251
};
310-
186E06FD2DDDF10600E32490 /* PBXTargetDependency */ = {
311-
isa = PBXTargetDependency;
312-
target = 186E06DA2DDDF10500E32490 /* BeforeGoing */;
313-
targetProxy = 186E06FC2DDDF10600E32490 /* PBXContainerItemProxy */;
314-
};
315252
/* End PBXTargetDependency section */
316253

317254
/* Begin XCBuildConfiguration section */
@@ -556,44 +493,6 @@
556493
};
557494
name = Release;
558495
};
559-
186E070D2DDDF10600E32490 /* Debug */ = {
560-
isa = XCBuildConfiguration;
561-
buildSettings = {
562-
CODE_SIGN_IDENTITY = "Apple Development";
563-
CODE_SIGN_STYLE = Automatic;
564-
CURRENT_PROJECT_VERSION = 6;
565-
DEVELOPMENT_TEAM = G6423FVY8X;
566-
GENERATE_INFOPLIST_FILE = YES;
567-
MARKETING_VERSION = 1.0;
568-
PRODUCT_BUNDLE_IDENTIFIER = com.und.BeforeGoingUITests;
569-
PRODUCT_NAME = "$(TARGET_NAME)";
570-
PROVISIONING_PROFILE_SPECIFIER = "";
571-
SWIFT_EMIT_LOC_STRINGS = NO;
572-
SWIFT_VERSION = 5.0;
573-
TARGETED_DEVICE_FAMILY = "1,2";
574-
TEST_TARGET_NAME = BeforeGoing;
575-
};
576-
name = Debug;
577-
};
578-
186E070E2DDDF10600E32490 /* Release */ = {
579-
isa = XCBuildConfiguration;
580-
buildSettings = {
581-
CODE_SIGN_IDENTITY = "Apple Development";
582-
CODE_SIGN_STYLE = Automatic;
583-
CURRENT_PROJECT_VERSION = 6;
584-
DEVELOPMENT_TEAM = G6423FVY8X;
585-
GENERATE_INFOPLIST_FILE = YES;
586-
MARKETING_VERSION = 1.0;
587-
PRODUCT_BUNDLE_IDENTIFIER = com.und.BeforeGoingUITests;
588-
PRODUCT_NAME = "$(TARGET_NAME)";
589-
PROVISIONING_PROFILE_SPECIFIER = "";
590-
SWIFT_EMIT_LOC_STRINGS = NO;
591-
SWIFT_VERSION = 5.0;
592-
TARGETED_DEVICE_FAMILY = "1,2";
593-
TEST_TARGET_NAME = BeforeGoing;
594-
};
595-
name = Release;
596-
};
597496
/* End XCBuildConfiguration section */
598497

599498
/* Begin XCConfigurationList section */
@@ -624,15 +523,6 @@
624523
defaultConfigurationIsVisible = 0;
625524
defaultConfigurationName = Release;
626525
};
627-
186E070C2DDDF10600E32490 /* Build configuration list for PBXNativeTarget "BeforeGoingUITests" */ = {
628-
isa = XCConfigurationList;
629-
buildConfigurations = (
630-
186E070D2DDDF10600E32490 /* Debug */,
631-
186E070E2DDDF10600E32490 /* Release */,
632-
);
633-
defaultConfigurationIsVisible = 0;
634-
defaultConfigurationName = Release;
635-
};
636526
/* End XCConfigurationList section */
637527

638528
/* Begin XCRemoteSwiftPackageReference section */

‎BeforeGoing/Core/BeforeGoingLogger.swift‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@ struct BeforeGoingLogger {
7373

7474
switch level {
7575
case .network:
76-
logger.log("[🛜 Network] [Date: \(date)] [\(fileName) -> \(function)]: \(logMessage)")
76+
logger.log("[🛜 Network] [Date: \(date)] [\(fileName, privacy: .public) -> \(function, privacy: .public)]: \(logMessage, privacy: .public)")
7777
case .data:
78-
logger.info("[📊 Data] [Date: \(date)] [\(fileName) -> \(function)]: \(logMessage)")
78+
logger.info("[📊 Data] [Date: \(date)] [\(fileName, privacy: .public) -> \(function, privacy: .public)]: \(logMessage, privacy: .public)")
7979
case .error(let error):
80-
logger.error("[❌ Error] [Date: \(date)] [\(fileName) -> \(function)]: \(error.localizedDescription)")
80+
logger.error("[❌ Error] [Date: \(date)] [\(fileName, privacy: .public) -> \(function, privacy: .public)]: \(error.localizedDescription)")
8181
}
8282
}
8383

‎fastlane/Fastfile‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ platform :ios do
2525
result_bundle: true,
2626
code_coverage: true,
2727
output_directory: ".",
28-
output_types: "junit,xcresult",
29-
skip_testing: ["BeforeGoingUITests"]
28+
output_types: "junit,xcresult"
3029
)
3130
end
3231

0 commit comments

Comments
 (0)