Email-confirmation (#35)

* Let new users confirm their email for registration

* Remove subtitle in permit statement

Author: tclaus

app/controllers/admins_controller.rb

@@ -40,7 +40,7 @@ def add_invites
 
   def weekly_user_stats
     @created_users_by_week = Hash.new{ |h,k| h[k] = [] }
-    @created_users = User.where("username IS NOT NULL and created_at IS NOT NULL")
+    @created_users = User.where("username IS NOT NULL and created_at IS NOT NULL and confirmed_at IS NOT NULL")
     @created_users.find_each do |u|
       week = u.created_at.beginning_of_week.strftime("%Y-%m-%d")
       @created_users_by_week[week] << {username: u.username, closed_account: u.person.closed_account}

app/controllers/registrations_controller.rb

@@ -52,7 +52,7 @@ def user_params
     params.require(:user).permit(
       :username, :email, :getting_started, :password, :password_confirmation, :language, :disable_mail,
       :show_community_spotlight_in_stream, :auto_follow_back, :auto_follow_back_aspect_id,
-      :remember_me, :subtitle
+      :remember_me
     )
   end
 end

app/models/comment.rb

@@ -102,8 +102,10 @@ def save_parent_comment_guid
 
   def min_time_delay
     return unless author.local?
+    last_comment = last_created_comment
+    return unless last_comment
 
-    return if last_created_comment.created_at < 1.minute.ago
+    return if last_comment.created_at < 1.minute.ago
 
     logger.info "Comment created too quickly"
     errors.add(:base, "Comments can only be created once per minute")

app/models/user.rb

@@ -28,6 +28,7 @@ class User < ApplicationRecord
   devise :registerable,
          :recoverable, :rememberable, :trackable, :validatable,
          :lockable, :lastseenable, lock_strategy: :none, unlock_strategy: :none
+  devise :confirmable
 
   before_validation :strip_and_downcase_username
   before_validation :set_current_language, on: :create

db/migrate/20250227072324_add_confirmable_to_devise.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+class AddConfirmableToDevise < ActiveRecord::Migration[6.1]
+  # rubocop:disable Rails/*
+  def change
+    add_column :users, :confirmation_token, :string
+    add_column :users, :confirmed_at, :datetime
+    add_column :users, :confirmation_sent_at, :datetime
+    add_index :users, :confirmation_token, unique: true
+
+    User.update_all(confirmed_at: Time.current)
+  end
+  # rubocop:enable Rails/*
+end