claude normalizes tar error messages

Author: tbeseda

src/extract.ts

@@ -3,6 +3,39 @@ import { mkdir } from 'node:fs/promises'
 import { platform } from 'node:os'
 import { resolve } from 'node:path'
 
+/**
+ * Normalizes tar error messages across different platforms
+ */
+function normalizeTarError(stderr: string): string {
+  const errorMessage = stderr.trim()
+
+  // File not found errors
+  if (
+    errorMessage.includes('Cannot open') ||
+    errorMessage.includes('Failed to open') ||
+    errorMessage.includes('No such file or directory')
+  ) {
+    return 'tar command failed: File not found'
+  }
+
+  // Invalid archive format errors
+  if (
+    errorMessage.includes('Unrecognized archive format') ||
+    errorMessage.includes('Error opening archive') ||
+    errorMessage.includes('incorrect header check')
+  ) {
+    return 'tar command failed: Invalid archive format'
+  }
+
+  // General extraction errors
+  if (errorMessage.includes('Error is not recoverable') || errorMessage.includes('Child returned status')) {
+    return 'tar command failed: Extraction error'
+  }
+
+  // If no specific pattern matches, return a generic message
+  return `tar command failed: ${errorMessage}`
+}
+
 export async function extractTarGz(archivePath: string, outputDir: string): Promise<void> {
   await mkdir(outputDir, { recursive: true })
 
@@ -21,8 +54,8 @@ export async function extractTarGz(archivePath: string, outputDir: string): Prom
       if (code === 0) {
         resolve()
       } else {
-        // Include stderr in error message for better debugging
-        const errorMsg = stderr.trim() || `${tarCmd} command failed with code ${code}`
+        // Normalize error message for consistent cross-platform behavior
+        const errorMsg = stderr.trim() ? normalizeTarError(stderr) : `${tarCmd} command failed with code ${code}`
         reject(new Error(errorMsg))
       }
     })

test/extract.test.ts

@@ -19,10 +19,7 @@ describe('Archive Extraction', () => {
       await extractArchive(archivePath, testDir)
     } catch (error) {
       // Expected to fail with gzip/tar error from our native implementation
-      assert.match(
-        (error as Error).message,
-        /tar command failed|Failed to extract|incorrect header check|Error opening archive/,
-      )
+      assert.match((error as Error).message, /tar command failed: Invalid archive format/)
     }
 
     // Clean up

test/tar-extraction.test.ts

@@ -43,7 +43,7 @@ describe('Native tar.gz Extraction Edge Cases', () => {
     try {
       await assert.rejects(
         async () => await extractTarGz(archivePath, testDir),
-        /No files extracted from archive|tar command failed|Error opening archive/,
+        /tar command failed: Invalid archive format/,
       )
     } finally {
       await rm(testDir, { recursive: true }).catch(() => {})
@@ -67,7 +67,7 @@ describe('Native tar.gz Extraction Edge Cases', () => {
     try {
       await assert.rejects(
         async () => await extractTarGz(archivePath, testDir),
-        /No files extracted from archive|tar command failed|Error opening archive/,
+        /tar command failed: Invalid archive format/,
       )
     } finally {
       await rm(testDir, { recursive: true }).catch(() => {})
@@ -80,7 +80,7 @@ describe('Native tar.gz Extraction Edge Cases', () => {
 
     await assert.rejects(
       async () => await extractTarGz(nonExistentPath, outputDir),
-      /tar command failed|Failed to open/,
+      /tar command failed: File not found/,
     )
   })