Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes for tip #3

Merged
merged 6 commits into from
Feb 20, 2012
Merged

Build fixes for tip #3

merged 6 commits into from
Feb 20, 2012

Conversation

bsiegert
Copy link
Contributor

Please apply these changes. They fix the build for Go1. Additionally, the Makefile has been replaced by build annotations for the platform-specific code.

tarm added a commit that referenced this pull request Feb 20, 2012
@tarm tarm merged commit 6e81330 into tarm:master Feb 20, 2012
@tarm
Copy link
Owner

tarm commented Feb 20, 2012

Thanks!

I've been meaning to make those changes when I had the time!

-Tarm

On Mon, Feb 20, 2012 at 10:44 AM, Benny Siegert
[email protected]
wrote:

Please apply these changes. They fix the build for Go1. Additionnally, the Makefile has been replaced by build annotations for the platform-specific code.

You can merge this Pull Request by running:

 git pull https://github.com/bsiegert/goserial master

Or you can view, comment on it, or merge it online at:

 tarm/goserial#3

-- Commit Summary --

  • Remove now-obsolete Makefile.
  • Rename darwin to posix, add build constraint comments.
  • Use O_foo constants from syscall, they are no longer in package os.
  • Skip the connection test if test.short is used.
  • Use uintptr for os.NewFile.
  • gofmt

-- File Changes --

D Makefile (12)
M basic_test.go (3)
D serial_linux.go (1)
R serial_posix.go (5)
M serial_windows.go (4)

-- Patch Links --

 https://github.com/tarm/goserial/pull/3.patch
 https://github.com/tarm/goserial/pull/3.diff


Reply to this email directly or view it on GitHub:
tarm/goserial#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants