serial_posix: fix even parity

akavel · web-flow · commit d85ea5599024 · 2017-05-09T14:32:37.000+02:00
Previously, when even parity was requested, PARODD was erroneously retained, and thus could actually result in odd parity being set (retained from what was set by tcgetattr)
diff --git a/serial_posix.go b/serial_posix.go
@@ -113,6 +113,7 @@ func openPort(name string, baud int, databits byte, parity Parity, stopbits Stop
 		st.c_cflag |= C.PARODD
 	case ParityEven:
 		st.c_cflag |= C.PARENB
+		st.c_cflag &= ^C.tcflag_t(C.PARODD)
 	default:
 		return nil, ErrBadParity
 	}

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ func openPort(name string, baud int, databits byte, parity Parity, stopbits Stop`
`113`	`113`	`st.c_cflag \|= C.PARODD`
`114`	`114`	`case ParityEven:`
`115`	`115`	`st.c_cflag \|= C.PARENB`
	`116`	`+ st.c_cflag &= ^C.tcflag_t(C.PARODD)`
`116`	`117`	`default:`
`117`	`118`	`return nil, ErrBadParity`
`118`	`119`	`}`