Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export as Image doesn't work in dark mode #651

Open
menghif opened this issue Jun 8, 2024 · 2 comments · May be fixed by #652
Open

Export as Image doesn't work in dark mode #651

menghif opened this issue Jun 8, 2024 · 2 comments · May be fixed by #652
Assignees

Comments

@menghif
Copy link
Collaborator

menghif commented Jun 8, 2024

"Export as Image" doesn't include text when exported from dark mode:

image in light mode image in dark mode
@rjwignar
Copy link
Collaborator

rjwignar commented Jun 8, 2024

I think this is because in dark mode the body text is white and camouflages into the white background.
I modified the text to red using my browser's dev tools and was able to get the text to appear:
image

I haven't verified this, but I think the white text in the code blocks and rendered diagrams are unaffected by virtue of being in their own subcomponents.

@rjwignar
Copy link
Collaborator

rjwignar commented Jun 8, 2024

I might be wrong, but it seems the handler takes a screenshot of the message CardBody.
I wonder if capturing the entire Card instead would fix this issue (so the text would be visible in its respective background)

@rjwignar rjwignar self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants