lint: enabled errcheck

Tests and methods are updated with enabling `errcheck`
for `golangci-lint` check.

Fixes #334

Author: ermyar

.golangci.yaml

@@ -2,9 +2,8 @@ run:
   timeout: 3m
 
 linters:
-  disable:
-    - errcheck
   enable:
+    - errcheck
     - forbidigo
     - gocritic
     - goimports

CHANGELOG.md

@@ -12,6 +12,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
 
 * New types for MessagePack extensions compatible with go-option (#459).
 * Added `box.MustNew` wrapper for `box.New` without an error (#448).
+* Enabled `errcheck` in linter.
 
 ### Changed
 

arrow/request_test.go

@@ -42,9 +42,9 @@ func TestResponseDecode(t *testing.T) {
 	buf := bytes.NewBuffer([]byte{})
 	enc := msgpack.NewEncoder(buf)
 
-	enc.EncodeMapLen(1)
-	enc.EncodeUint8(uint8(iproto.IPROTO_DATA))
-	enc.Encode([]interface{}{'v', '2'})
+	_ = enc.EncodeMapLen(1)
+	_ = enc.EncodeUint8(uint8(iproto.IPROTO_DATA))
+	_ = enc.Encode([]interface{}{'v', '2'})
 
 	request := arrow.NewInsertRequest(validSpace, arrow.Arrow{})
 	resp, err := request.Response(header, bytes.NewBuffer(buf.Bytes()))
@@ -61,9 +61,9 @@ func TestResponseDecodeTyped(t *testing.T) {
 	buf := bytes.NewBuffer([]byte{})
 	enc := msgpack.NewEncoder(buf)
 
-	enc.EncodeMapLen(1)
-	enc.EncodeUint8(uint8(iproto.IPROTO_DATA))
-	enc.EncodeBytes([]byte{'v', '2'})
+	_ = enc.EncodeMapLen(1)
+	_ = enc.EncodeUint8(uint8(iproto.IPROTO_DATA))
+	_ = enc.EncodeBytes([]byte{'v', '2'})
 
 	request := arrow.NewInsertRequest(validSpace, arrow.Arrow{})
 	resp, err := request.Response(header, bytes.NewBuffer(buf.Bytes()))

box/box_test.go

@@ -38,7 +38,7 @@ func TestMocked_BoxNew(t *testing.T) {
 	require.NotNil(t, b)
 
 	assert.Len(t, mock.Requests, 0)
-	b.Schema().User().Exists(box.NewInfoRequest().Ctx(), "")
+	_, _ = b.Schema().User().Exists(box.NewInfoRequest().Ctx(), "")
 	require.Len(t, mock.Requests, 1)
 }
 

boxerror_test.go

@@ -204,7 +204,7 @@ func TestMessagePackDecode(t *testing.T) {
 func TestMessagePackUnmarshalToNil(t *testing.T) {
 	var val *BoxError = nil
 	require.PanicsWithValue(t, "cannot unmarshal to a nil pointer",
-		func() { val.UnmarshalMsgpack(mpDecodeSamples["InnerMapExtraKey"].b) })
+		func() { _ = val.UnmarshalMsgpack(mpDecodeSamples["InnerMapExtraKey"].b) })
 }
 
 func TestMessagePackEncodeNil(t *testing.T) {

client_tools.go

@@ -11,8 +11,8 @@ type IntKey struct {
 }
 
 func (k IntKey) EncodeMsgpack(enc *msgpack.Encoder) error {
-	enc.EncodeArrayLen(1)
-	enc.EncodeInt(int64(k.I))
+	_ = enc.EncodeArrayLen(1)
+	_ = enc.EncodeInt(int64(k.I))
 	return nil
 }
 
@@ -24,8 +24,8 @@ type UintKey struct {
 }
 
 func (k UintKey) EncodeMsgpack(enc *msgpack.Encoder) error {
-	enc.EncodeArrayLen(1)
-	enc.EncodeUint(uint64(k.I))
+	_ = enc.EncodeArrayLen(1)
+	_ = enc.EncodeUint(uint64(k.I))
 	return nil
 }
 
@@ -36,8 +36,8 @@ type StringKey struct {
 }
 
 func (k StringKey) EncodeMsgpack(enc *msgpack.Encoder) error {
-	enc.EncodeArrayLen(1)
-	enc.EncodeString(k.S)
+	_ = enc.EncodeArrayLen(1)
+	_ = enc.EncodeString(k.S)
 	return nil
 }
 
@@ -48,9 +48,9 @@ type IntIntKey struct {
 }
 
 func (k IntIntKey) EncodeMsgpack(enc *msgpack.Encoder) error {
-	enc.EncodeArrayLen(2)
-	enc.EncodeInt(int64(k.I1))
-	enc.EncodeInt(int64(k.I2))
+	_ = enc.EncodeArrayLen(2)
+	_ = enc.EncodeInt(int64(k.I1))
+	_ = enc.EncodeInt(int64(k.I2))
 	return nil
 }
 

connection.go

@@ -401,7 +401,7 @@ func Connect(ctx context.Context, dialer Dialer, opts Opts) (conn *Connection, e
 		if err != nil {
 			conn.mutex.Lock()
 			defer conn.mutex.Unlock()
-			conn.closeConnection(err, true)
+			_ = conn.closeConnection(err, true)
 			return nil, err
 		}
 		conn.SetSchema(schema)
@@ -562,7 +562,7 @@ func pack(h *smallWBuf, enc *msgpack.Encoder, reqid uint32,
 		byte(reqid >> 8), byte(reqid),
 	}, streamBytes[:streamBytesLen]...)
 
-	h.Write(hBytes)
+	_, _ = h.Write(hBytes)
 
 	if err = req.Body(res, enc); err != nil {
 		return
@@ -695,13 +695,13 @@ func (conn *Connection) runReconnects(ctx context.Context) error {
 func (conn *Connection) reconnectImpl(neterr error, c Conn) {
 	if conn.opts.Reconnect > 0 {
 		if c == conn.c {
-			conn.closeConnection(neterr, false)
+			_ = conn.closeConnection(neterr, false)
 			if err := conn.runReconnects(context.Background()); err != nil {
-				conn.closeConnection(err, true)
+				_ = conn.closeConnection(err, true)
 			}
 		}
 	} else {
-		conn.closeConnection(neterr, true)
+		_ = conn.closeConnection(neterr, true)
 	}
 }
 
@@ -1106,7 +1106,7 @@ func (conn *Connection) putFuture(fut *Future, req Request, streamId uint64) {
 				RequestId: reqid,
 				Error:     ErrorNo,
 			}
-			fut.SetResponse(header, nil)
+			_ = fut.SetResponse(header, nil)
 			conn.markDone(fut)
 		}
 	}
@@ -1482,7 +1482,7 @@ func (conn *Connection) newWatcherImpl(key string, callback WatchCallback) (Watc
 					// request will not be finished by a small per-request
 					// timeout.
 					req := newWatchRequest(key).Context(context.Background())
-					conn.Do(req).Get()
+					_, _ = conn.Do(req).Get()
 				}
 			}
 
@@ -1505,7 +1505,7 @@ func (conn *Connection) newWatcherImpl(key string, callback WatchCallback) (Watc
 						// not be finished by a small per-request timeout to
 						// avoid lost of the request.
 						req := newUnwatchRequest(key).Context(context.Background())
-						conn.Do(req).Get()
+						_, _ = conn.Do(req).Get()
 					}
 					conn.watchMap.Delete(key)
 					close(state.unready)
@@ -1538,7 +1538,9 @@ func shutdownEventCallback(event WatchEvent) {
 	// step 2.
 	val, ok := event.Value.(bool)
 	if ok && val {
-		go event.Conn.shutdown(false)
+		go func() {
+			_ = event.Conn.shutdown(false)
+		}()
 	}
 }
 

crud/object.go

@@ -20,5 +20,5 @@ type Objects = interface{}
 type MapObject map[string]interface{}
 
 func (o MapObject) EncodeMsgpack(enc *msgpack.Encoder) {
-	enc.Encode(o)
+	_ = enc.Encode(o)
 }

crud/options.go

@@ -398,8 +398,8 @@ func encodeOptions(enc *msgpack.Encoder,
 	if mapLen > 0 {
 		for i, name := range names {
 			if exists[i] {
-				enc.EncodeString(name)
-				enc.Encode(values[i])
+				_ = enc.EncodeString(name)
+				_ = enc.Encode(values[i])
 			}
 		}
 	}

crud/tarantool_test.go

@@ -559,7 +559,7 @@ func TestCrudGenerateData(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 
 			data, err := conn.Do(testCase.req).Get()
@@ -571,7 +571,7 @@ func TestCrudGenerateData(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 		})
 	}
@@ -590,7 +590,7 @@ func TestCrudProcessData(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 		})
 	}
@@ -799,7 +799,7 @@ func TestBoolResult(t *testing.T) {
 	for i := 1010; i < 1020; i++ {
 		req := tarantool.NewDeleteRequest(spaceName).
 			Key([]interface{}{uint(i)})
-		conn.Do(req).Get()
+		_, _ = conn.Do(req).Get()
 	}
 }
 
@@ -824,7 +824,7 @@ func TestNumberResult(t *testing.T) {
 	for i := 1010; i < 1020; i++ {
 		req := tarantool.NewDeleteRequest(spaceName).
 			Key([]interface{}{uint(i)})
-		conn.Do(req).Get()
+		_, _ = conn.Do(req).Get()
 	}
 }
 
@@ -869,7 +869,7 @@ func TestBaseResult(t *testing.T) {
 	for i := 1010; i < 1020; i++ {
 		req := tarantool.NewDeleteRequest(spaceName).
 			Key([]interface{}{uint(i)})
-		conn.Do(req).Get()
+		_, _ = conn.Do(req).Get()
 	}
 }
 
@@ -914,7 +914,7 @@ func TestManyResult(t *testing.T) {
 	for i := 1010; i < 1020; i++ {
 		req := tarantool.NewDeleteRequest(spaceName).
 			Key([]interface{}{uint(i)})
-		conn.Do(req).Get()
+		_, _ = conn.Do(req).Get()
 	}
 }
 
@@ -1130,7 +1130,7 @@ func TestFetchLatestMetadataOption(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 
 			resp := crud.Result{}
@@ -1147,7 +1147,7 @@ func TestFetchLatestMetadataOption(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 		})
 	}
@@ -1283,7 +1283,7 @@ func TestNoreturnOption(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 
 			data, err := conn.Do(testCase.req).Get()
@@ -1306,7 +1306,7 @@ func TestNoreturnOption(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 		})
 	}
@@ -1321,7 +1321,7 @@ func TestNoreturnOptionTyped(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 
 			resp := crud.Result{}
@@ -1342,7 +1342,7 @@ func TestNoreturnOptionTyped(t *testing.T) {
 			for i := 1010; i < 1020; i++ {
 				req := tarantool.NewDeleteRequest(spaceName).
 					Key([]interface{}{uint(i)})
-				conn.Do(req).Get()
+				_, _ = conn.Do(req).Get()
 			}
 		})
 	}