Skip to content

Commit f2d00a9

Browse files
committed
fix: testcode
1 parent 6420307 commit f2d00a9

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

core/src/main/java/org/testcontainers/dockerclient/DockerClientProviderStrategy.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -403,9 +403,9 @@ public static DockerClient getClientForConfig(TransportConfig transportConfig) {
403403

404404
DefaultDockerClientConfig.Builder configBuilder = DefaultDockerClientConfig.createDefaultConfigBuilder();
405405

406-
if (configBuilder.build().getApiVersion() == RemoteApiVersion.UNKNOWN_VERSION) {
407-
configBuilder.withApiVersion(RemoteApiVersion.VERSION_1_44);
408-
}
406+
// if (configBuilder.build().getApiVersion() == RemoteApiVersion.UNKNOWN_VERSION) {
407+
// configBuilder.withApiVersion(RemoteApiVersion.VERSION_1_44);
408+
// }
409409
Map<String, String> headers = new HashMap<>();
410410
headers.put("x-tc-sid", DockerClientFactory.SESSION_ID);
411411
headers.put("User-Agent", String.format("tc-java/%s", DockerClientFactory.TESTCONTAINERS_VERSION));

core/src/test/java/org/testcontainers/containers/DockerMcpGatewayContainerTest.java

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,30 @@
55
import java.util.Collections;
66

77
import static org.assertj.core.api.Assertions.assertThat;
8+
import org.testcontainers.containers.output.Slf4jLogConsumer;
9+
import org.slf4j.LoggerFactory;
810

911
class DockerMcpGatewayContainerTest {
1012

1113
@Test
12-
void serviceSuccessfullyStarts() {
13-
try (DockerMcpGatewayContainer gateway = new DockerMcpGatewayContainer("docker/mcp-gateway:latest")) {
14-
gateway.start();
14+
public void serviceSuccessfullyStarts() {
15+
DockerMcpGatewayContainer container = new DockerMcpGatewayContainer("docker/mcp-gateway:latest")
16+
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("MCP-Container")));
17+
18+
try {
19+
container.start();
20+
21+
assertThat(container.isRunning()).isTrue();
1522

16-
assertThat(gateway.isRunning()).isTrue();
23+
} catch (Exception e) {
24+
throw e;
25+
26+
} finally {
27+
if (container != null) {
28+
container.stop();
1729
}
1830
}
31+
}
1932

2033
@Test
2134
void gatewayStartsWithServers() {

0 commit comments

Comments
 (0)