merge develop branch for release 2.1.8

Author: Jim Olsen

BUILD/lib/script_definitions.py

@@ -165,7 +165,7 @@
 
 sname = 'tsat'
 scripts[sname] = {}
-scripts[sname]['docstring'] = 'Tanium Sensor Analysis Tool: asks a question for every sensor and saves theresults as CSV reports'
+scripts[sname]['docstring'] = 'Tanium Sensor Analysis Tool: asks a question for every sensor and saves the results as report files'
 scripts[sname]['script_name'] = sname
 scripts[sname]['pyopts'] = ''
 scripts[sname]['py_template'] = '${py_script}'

CHANGELOG.md

@@ -1,31 +1,33 @@
 <!-- MarkdownTOC -->
 
+- [2.1.9](#219)
 - [2.1.8](#218)
-- [2.1.7](#217)
   - [enhancements](#enhancements)
+- [2.1.7](#217)
+  - [enhancements](#enhancements-1)
   - [doc updates](#doc-updates)
   - [bug fixes](#bug-fixes)
   - [work in progress](#work-in-progress)
   - [notes](#notes)
 - [2.1.6](#216)
-  - [enhancements](#enhancements-1)
+  - [enhancements](#enhancements-2)
 - [2.1.5](#215)
   - [bug fixes](#bug-fixes-1)
-  - [enhancements](#enhancements-2)
+  - [enhancements](#enhancements-3)
 - [2.1.4](#214)
   - [bug fixes](#bug-fixes-2)
-  - [enhancements](#enhancements-3)
+  - [enhancements](#enhancements-4)
   - [doc updates](#doc-updates-1)
   - [test updates](#test-updates)
 - [2.1.3](#213)
-  - [enhancements](#enhancements-4)
+  - [enhancements](#enhancements-5)
 - [2.1.2](#212)
   - [bug fixes](#bug-fixes-3)
 - [2.1.1](#211)
-  - [enhancements](#enhancements-5)
+  - [enhancements](#enhancements-6)
 - [2.1.0](#210)
   - [bug fixes](#bug-fixes-4)
-  - [enhancements](#enhancements-6)
+  - [enhancements](#enhancements-7)
   - [doc updates](#doc-updates-2)
 - [2.0.3](#203)
 - [2.0.2](#202)
@@ -43,10 +45,18 @@
 
 <!-- /MarkdownTOC -->
 
-# 2.1.8
+# 2.1.9
 
 [Development branch](https://github.com/tanium/pytan/tree/develop) on N/A
 
+# 2.1.8
+
+[Released](https://github.com/tanium/pytan/releases/tag/2.1.8) on Jan 19 2016
+
+## enhancements
+* TSAT logging improvement: add file log handler to ALL loggers, not just TSAT log
+* added complete_pct arg for ask_manual to binsupport.py
+
 # 2.1.7
 
 [Released](https://github.com/tanium/pytan/releases/tag/2.1.7) on Dec 08 2015 

TODO.md

@@ -24,9 +24,10 @@
 * work on deploy action & start_seconds_from_now (a new action gets created at actual start time)
 * on 6.2, block info.json (block 444), fix _regex_for_body_element when _get_response tries to parse for server_version but it doesn't exist
 * param with \ at end breaks parameter parser regex
+* ~~ Will store value as global in TSAT
 
 ## GEN
-* TSAT re-vival
+* fix filename of datetime stamp in win
 * bring new session scripts into build system
 * 2.1.7: ask_saved: 
   * add log for get_result_info in refresh_data path
@@ -43,6 +44,7 @@
 * question filters get params too?? (UNKNOWN)
 * add json source for parameters in TSAT
 * add export_obj option for csv to split columns longer than 32k
+* refactor utils/binsupport (3.x)
 
 ## TEST
 * add approve action to pytan (need doc update and test update)
@@ -61,12 +63,9 @@
 ## LOW
 * bundle workflow capture into handler?
 * fix build bin doc to run on windows (figure out later)
-* write get_session_id.py (later)
-* update EXAMPLES to work with 2.0.0
 * look into update object methods (UNKNOWN)
 * logfile support (MEDIUM)
 * email out (MEDIUM)
 * add caching (HUGE)
 * figure out cert based auth/plugin based auth? (HUGE)
 * add RST output support to mdtester?
-* add os env overrides and/or add profile overrides

lib/pytan/__init__.py

@@ -4,7 +4,7 @@
 '''A python package that makes using the Tanium Server SOAP API easy.'''
 
 __title__ = 'PyTan'
-__version__ = '2.1.7'
+__version__ = '2.1.8'
 """
 Version of PyTan
 """

lib/pytan/binsupport.py

@@ -1637,6 +1637,15 @@ def setup_ask_manual_argparser(doc):
         help='Get the results after asking the quesiton '
         '(default)',
     )
+    group.add_argument(
+        '--complete_pct',
+        required=False,
+        type=float,
+        action='store',
+        default=pytan.pollers.QuestionPoller.COMPLETE_PCT_DEFAULT,
+        dest='complete_pct',
+        help='Percent to consider questions complete',
+    )
     parser = add_ask_report_argparser(parser=parser)
     return parser
 
@@ -2354,31 +2363,28 @@ def set_log_level(self):
 
     def remove_file_log(self, logfile):
         """Utility to remove a log file from python's logging module"""
+        self.mylog.debug('Removing file logging to: {}'.format(logfile))
         basename = os.path.basename(logfile)
         root_logger = logging.getLogger()
-        try:
-            for x in root_logger.handlers:
+        all_loggers = pytan.utils.get_all_loggers()
+        for k, v in all_loggers.items():
+            for x in v.handlers:
                 if x.name == basename:
                     root_logger.removeHandler(x)
-                    self.mylog.debug('Stopped file logging to: {}'.format(logfile))
-        except:
-            pass
 
     def add_file_log(self, logfile):
         """Utility to add a log file from python's logging module"""
         self.remove_file_log(logfile)
-        root_logger = logging.getLogger()
+        self.mylog.debug('Adding file logging to: {}'.format(logfile))
+        all_loggers = pytan.utils.get_all_loggers()
         basename = os.path.basename(logfile)
-        try:
-            self.mylog.debug('Adding file logging to: {}'.format(logfile))
-            file_handler = logging.FileHandler(logfile)
-            file_handler.set_name(basename)
-            file_handler.setLevel(logging.DEBUG)
-            file_handler.setFormatter(logging.Formatter(self.FILE_INFO_FORMAT))
-            root_logger.addHandler(file_handler)
-        except Exception as e:
-            self.mylog.error('Problem setting up file logging to {}: {}'.format(logfile, e))
-            raise
+        file_handler = logging.FileHandler(logfile)
+        file_handler.set_name(basename)
+        file_handler.setLevel(logging.DEBUG)
+        file_handler.setFormatter(logging.Formatter(self.FILE_INFO_FORMAT))
+        for k, v in all_loggers.items():
+            v.addHandler(file_handler)
+            v.propagate = False
 
     def set_mylog(self):
         logging.Formatter.converter = time.gmtime