Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated filter #55

Open
matkoniecz opened this issue Oct 28, 2017 · 1 comment
Open

duplicated filter #55

matkoniecz opened this issue Oct 28, 2017 · 1 comment

Comments

@matkoniecz
Copy link
Contributor

https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L850
https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L851

https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L888
https://github.com/tangrams/cinnabar-style/blob/gh-pages/cinnabar-style.yaml#L889

first line is completely useless an second has smaller requirement

not sure what is the intended meaning - delete first/second line? Decrement all z-levels from lowest to first duplicated? Increment all from first duplicated to highest?

@matkoniecz
Copy link
Contributor Author

Also, not sure is it available but filtering by displayed area rather than real area would be probably more readable and less error prone - like at https://github.com/gravitystorm/openstreetmap-carto/blob/master/water.mss#L322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant