Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installable native PWA #1

Open
zopieux opened this issue Nov 2, 2024 · 3 comments
Open

Installable native PWA #1

zopieux opened this issue Nov 2, 2024 · 3 comments

Comments

@zopieux
Copy link

zopieux commented Nov 2, 2024

Hi,

Thanks for developing PeerSplit, it looks great and was exactly how I envisioned a p2p Splitwise clone to work!

In the current state however, the app is not an installable PWA proper, which looks much better on Android ("native" app icon, less browser chrome, ...). Adding as a shortcut (as documented) works okay but is less convenient, for instance it clutters the browser's tabs.

Given that there already is a dependency on vite-pwa I'd assume you're considering making it a proper installable PWA with a manifest. If not, consider this a feature request! 😄

@tanayvk
Copy link
Owner

tanayvk commented Nov 3, 2024

Hey @zopieux, thanks! Great catch.

Turns out I had commented out the line that registers the @vite-pwa/nuxt module and inadvertently committed it. (I was probably trying to test something locally.)

I’ve uncommented it and pushed the fix. PWA should be working now! :)

@tanayvk
Copy link
Owner

tanayvk commented Nov 3, 2024

9044ddb

@zopieux
Copy link
Author

zopieux commented Nov 3, 2024

Oh cool thanks. The actions tell me it should get deployed automatically but I see no difference even after refreshing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants