Skip to content

Commit e2ed14f

Browse files
authored
Merge pull request #13 from talocode/fix/desktop-contract-protocol-sync
fix: align desktop task contract and protocol sync
2 parents deaafca + 5b6bc63 commit e2ed14f

20 files changed

Lines changed: 2006 additions & 672 deletions

.github/workflows/ci.yml

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
name: CI
2+
3+
on:
4+
pull_request:
5+
push:
6+
branches:
7+
- main
8+
- master
9+
10+
jobs:
11+
desktop-contract-checks:
12+
name: Desktop contract checks
13+
runs-on: ubuntu-22.04
14+
15+
steps:
16+
- name: Check out repository
17+
uses: actions/checkout@v4
18+
19+
- name: Set up Node.js
20+
uses: actions/setup-node@v4
21+
with:
22+
node-version: 20
23+
24+
- name: Set up pnpm
25+
uses: pnpm/action-setup@v4
26+
with:
27+
version: 9
28+
29+
- name: Set up Rust toolchain
30+
uses: dtolnay/rust-toolchain@stable
31+
32+
- name: Install Linux desktop dependencies
33+
run: |
34+
sudo apt-get update
35+
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf
36+
37+
- name: Install workspace dependencies
38+
run: pnpm install --no-frozen-lockfile
39+
40+
- name: Check task-loop protocol sync
41+
run: pnpm check:task-loop-protocol-sync
42+
43+
- name: Build desktop app
44+
run: pnpm --filter desktop build
45+
46+
- name: Check desktop Tauri crate
47+
run: cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ Thank you for your interest in contributing to Codra by Talocode.
1212
6. **Run checks** before submitting:
1313
```bash
1414
pnpm install
15-
cargo check
15+
pnpm check:task-loop-protocol-sync
16+
pnpm --filter desktop build
17+
cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml
1618
```
1719

1820
## Code of Conduct

apps/desktop/src-tauri/src/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -869,8 +869,7 @@ fn codra_run_verification(
869869
) -> Result<codra_protocol::Task, String> {
870870
let task_store = TaskStore::new(&workspace_path);
871871
let verifier = TaskVerifier::<RealCommandRunner>::new(task_store.clone(), RealCommandRunner);
872-
// Simplified: just return the task after attempting verification
873-
let _ = verifier.run_verification(&task_id, None);
872+
verifier.run_verification(&task_id, None)?;
874873
task_store.load_task(&task_id)
875874
}
876875

0 commit comments

Comments
 (0)