Add missing return codes for security manager

[sampaioletti]

Add missing return codes for security manager to BLEReturnCode

esp32-nimble/src/ble_return_code.rs

Line 39 in 8f55ab5

pub fn return_code_to_string(rc: u32) -> Option<&'static str> {

https://mynewt.apache.org/latest/network/ble_hs/ble_hs_return_codes.html#return-codes-security-manager-us

As a secondary point might be useful to consider returning BLEReturnCode in some additional places. i.e.

esp32-nimble/src/server/ble_server.rs

Line 89 in 8f55ab5

callback: impl Fn(&BLEConnDesc, c_int) + Send + Sync + 'static,

instead of c_int, which then begs the question should BLEReturnCode inner be a i32 or is u32 correct.

esp32-nimble/src/ble_return_code.rs

Line 2 in 8f55ab5

pub struct BLEReturnCode(pub u32);

[taks]

Can you create a PR?

[sampaioletti]

Yeah I should have some time this week. I'll try and get something put together.

…

-Sam

________________________________ From: taks ***@***.***> Sent: Monday, February 19, 2024 7:04:29 PM To: taks/esp32-nimble ***@***.***> Cc: sam ***@***.***>; Author ***@***.***> Subject: Re: [taks/esp32-nimble] Add missing return codes for security manager (Issue #93) Can you create a PR? — Reply to this email directly, view it on GitHub<#93 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDGQ52OOV4KF665VUIGCMDYUQAC3AVCNFSM6AAAAABDP7BB7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGM3TCOBYHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[sampaioletti]

What is the reasoning behind the wrapped type for BLEReturnCode vs a more rusty Enum style error? Not a critique, just an ask.

[taks]

At the time of implementation,
if I was not sure whether the value could be converted to a BLEReturnCode, I used the value as it is.

It is better to replace BLEReturnCode if it can be replaced.